All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Aruna Jayasena <aruna.15@cse.mrt.ac.lk>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] Header cleanups- Tabs replaced with spaces
Date: Mon, 1 Apr 2019 10:39:32 +0100	[thread overview]
Message-ID: <20190401093932.GC3524@redhat.com> (raw)
In-Reply-To: <20190401082655.8272-2-aruna.15@cse.mrt.ac.lk>

On Mon, Apr 01, 2019 at 01:56:55PM +0530, Aruna Jayasena wrote:
> Declarations were moved out of qemu-common.h for functions declared in utils/ files.
> This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks
> 
> Signed-off-by: Aruna Jayasena <aruna.15@cse.mrt.ac.lk>
> 
> ---
>  include/qemu/id.h       | 4 ++--
>  include/qemu/readline.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/qemu/id.h b/include/qemu/id.h
> index 3a651fb9d2..f3451344e2 100644
> --- a/include/qemu/id.h
> +++ b/include/qemu/id.h
> @@ -1,8 +1,8 @@
>  #ifndef QEMU_ID_H
>  #define QEMU_ID_H
>  
> -#define qemu_isalnum(c)		isalnum((unsigned char)(c))
> -#define qemu_isalpha(c)		isalpha((unsigned char)(c))
> +#define qemu_isalnum(c)    isalnum((unsigned char)(c))
> +#define qemu_isalpha(c)    isalpha((unsigned char)(c))
>  
>  typedef enum IdSubSystems {
>      ID_QDEV,
> diff --git a/include/qemu/readline.h b/include/qemu/readline.h
> index 4cbf7ead5a..67859a3028 100644
> --- a/include/qemu/readline.h
> +++ b/include/qemu/readline.h
> @@ -1,7 +1,7 @@
>  #ifndef READLINE_H
>  #define READLINE_H
>  
> -#define qemu_isspace(c)		isspace((unsigned char)(c))
> +#define qemu_isspace(c)    isspace((unsigned char)(c))
>  
>  #define READLINE_CMD_BUF_SIZE 4095
>  #define READLINE_MAX_CMDS 64

This should just be fixed when moving the macros out of qemu-common.h

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2019-04-01  9:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01  8:26 [Qemu-devel] [PATCH 1/2] Header cleanups Aruna Jayasena
2019-04-01  8:26 ` [Qemu-devel] [PATCH 2/2] Header cleanups- Tabs replaced with spaces Aruna Jayasena
2019-04-01  9:39   ` Daniel P. Berrangé [this message]
2019-04-01 13:04     ` Philippe Mathieu-Daudé
2019-04-01  9:39 ` [Qemu-devel] [PATCH 1/2] Header cleanups Daniel P. Berrangé
  -- strict thread matches above, loose matches on Subject: below --
2019-04-01  9:05 Aruna Jayasena
2019-04-01  9:05 ` [Qemu-devel] [PATCH 2/2] Header cleanups- Tabs replaced with spaces Aruna Jayasena
2019-04-01  8:17 [Qemu-devel] [PATCH 1/2] Header cleanups Aruna Jayasena
2019-04-01  8:17 ` [Qemu-devel] [PATCH 2/2] Header cleanups- Tabs replaced with spaces Aruna Jayasena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401093932.GC3524@redhat.com \
    --to=berrange@redhat.com \
    --cc=aruna.15@cse.mrt.ac.lk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.