From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: typec: Registering real device entries for the muxes From: Greg Kroah-Hartman Message-Id: <20190401103429.GA12128@kroah.com> Date: Mon, 1 Apr 2019 12:34:29 +0200 To: Heikki Krogerus Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gTW9uLCBBcHIgMDEsIDIwMTkgYXQgMDE6MTU6NTNQTSArMDMwMCwgSGVpa2tpIEtyb2dlcnVz IHdyb3RlOgo+IFJlZ2lzdGVyaW5nIHJlYWwgZGV2aWNlIGVudHJpZXMgKHN0cnVjdCBkZXZpY2Up IGZvciB0aGUgbW9kZQo+IG11eGVzIGFzIHdlbGwgYXMgZm9yIHRoZSBvcmllbnRhdGlvbiBzd2l0 Y2hlcy4KPiAKPiBUaGUgVHlwZS1DIG11eCBjb2RlIHdhcyBkZWxpYmVyYXRlbHkgYXR0ZW1wdGlu ZyB0byBhdm9pZAo+IGNyZWF0aW9uIG9mIHNlcGFyYXRlIGRldmljZSBlbnRyaWVzIGZvciB0aGUg b3JpZW50YXRpb24KPiBzd2l0Y2ggYW5kIHRoZSBtb2RlIHN3aXRjaCAoYWx0ZXJuYXRlIG1vZGVz KSBiZWNhdXNlIHRoZXkKPiBhcmUgbm90IHBoeXNpY2FsIGRldmljZXMuIFRoZXkgYXJlIGZ1bmN0 aW9ucyBvZiBhIHNpbmdsZQo+IHBoeXNpY2FsIG11bHRpcGxleGVyL2RlbXVsdGlwbGV4ZXIgc3dp dGNoIGRldmljZS4KPiAKPiBVbmZvcnR1bmF0ZWx5IGJlY2F1c2Ugb2YgdGhlIGRlcGVuZGVuY3kg d2Ugc3RpbGwgaGF2ZSBvbiB0aGUKPiB1bmRlcmx5aW5nIG11eCBkZXZpY2UgZHJpdmVyLCB3ZSBo YWQgdG8gcHV0IGluIGhhY2tzIGxpa2UKPiB0aGUgb25lIGluIHRoZSBjb21taXQgM2UzYjgxOTY1 Y2JmICgidXNiOiB0eXBlYzogbXV4OiBUYWtlCj4gY2FyZSBvZiBkcml2ZXIgbW9kdWxlIHJlZmVy ZW5jZSBjb3VudGluZyIpIHRvIG1ha2Ugc3VyZSB0aGUKPiBkcml2ZXIgZG9lcyBub3QgZGlzYXBw ZWFyIGZyb20gdW5kZXJuZWF0aCB1cy4gRXZlbiB3aXRoCj4gdGhvc2UgaGFja3Mgd2Ugd2VyZSBz dGlsbCBsZWZ0IHdpdGggYSBwb3RlbnRpYWwgTlVsbCBwb2ludGVyCj4gZGVyZWZlcmVuY2Ugc2Nl bmFyaW8sIHNvIGp1c3QgY3JlYXRpbmcgdGhlIGRldmljZSBlbnRyaWVzLAo+IGFuZCBsZXR0aW5n IHRoZSBjb3JlIHRha2UgY2FyZSBvZiB0aGUgZGVwZW5kZW5jaWVzLiBObyBtb3JlCj4gaGFja3Mg bmVlZGVkLgo+IAo+IEZpeGVzOiAzZTNiODE5NjVjYmYgKCJ1c2I6IHR5cGVjOiBtdXg6IFRha2Ug Y2FyZSBvZiBkcml2ZXIgbW9kdWxlIHJlZmVyZW5jZSBjb3VudGluZyIpCj4gQ2M6IHY0LjE5Lngg PHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjQuMTkueCsKPiBTaWduZWQtb2ZmLWJ5OiBIZWlr a2kgS3JvZ2VydXMgPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5jb20+CgpUaGlzIGxvb2tz IGdvb2QgdG8gbWUsIG5pY2Ugd29yayEKCkJ1dCwgaXQgd291bGQgYmUgbmljZSBpZiBzb21lb25l IHdobyBoYXMgdGhpcyBoYXJkd2FyZSBjYW4gdGVzdCBpdCB0bwp2ZXJpZnkgaXQgZG9lcyBhY3R1 YWxseSB3b3JrIDopCgp0aGFua3MsCgpncmVnIGstaAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF872C43381 for ; Mon, 1 Apr 2019 10:34:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE5AD2082C for ; Mon, 1 Apr 2019 10:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554114872; bh=c4EDmAMUpF7Z10zRrpWMgWMVUvajJSCVZx08h28dxZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=A1kaFD/5z1+obsqxtwmm/kkSlnaakx/z4qAa0ZZjogreYWUvtwdUqX2LvJODwlqFC Ap4kTmjOte5yFBrXe5njvKEzKs209YL6/0CBZXbCTKyloq3CdiyVDxaTi56wL1W8iU 62NdzZWp6hN9tmezGOTf+yjOUEcvjXuITbfeqMn4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725882AbfDAKec (ORCPT ); Mon, 1 Apr 2019 06:34:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:33686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbfDAKeb (ORCPT ); Mon, 1 Apr 2019 06:34:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E56DB2082C; Mon, 1 Apr 2019 10:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554114871; bh=c4EDmAMUpF7Z10zRrpWMgWMVUvajJSCVZx08h28dxZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FL0TZZXnH/7GdDbQnucKfrLc5UQddybrVInjUX41yYNVQDP5Ozo6JIdjZWdOxlvhy sbmFydALgyV3vjqiNa5eUuOuXkN/Btl2F7jUjI6bW7arQY7YP5Ze2BdAcZNV3bNWfV z1HT9oywkPPgdL7oOBSXdtDpfosKLGbvtApVeeDU= Date: Mon, 1 Apr 2019 12:34:29 +0200 From: Greg KH To: Heikki Krogerus Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] usb: typec: Registering real device entries for the muxes Message-ID: <20190401103429.GA12128@kroah.com> References: <20190401101553.45680-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190401101553.45680-1-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 01, 2019 at 01:15:53PM +0300, Heikki Krogerus wrote: > Registering real device entries (struct device) for the mode > muxes as well as for the orientation switches. > > The Type-C mux code was deliberately attempting to avoid > creation of separate device entries for the orientation > switch and the mode switch (alternate modes) because they > are not physical devices. They are functions of a single > physical multiplexer/demultiplexer switch device. > > Unfortunately because of the dependency we still have on the > underlying mux device driver, we had to put in hacks like > the one in the commit 3e3b81965cbf ("usb: typec: mux: Take > care of driver module reference counting") to make sure the > driver does not disappear from underneath us. Even with > those hacks we were still left with a potential NUll pointer > dereference scenario, so just creating the device entries, > and letting the core take care of the dependencies. No more > hacks needed. > > Fixes: 3e3b81965cbf ("usb: typec: mux: Take care of driver module reference counting") > Cc: v4.19.x # v4.19.x+ > Signed-off-by: Heikki Krogerus This looks good to me, nice work! But, it would be nice if someone who has this hardware can test it to verify it does actually work :) thanks, greg k-h