All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: stable@vger.kernel.org, linux-wireless@vger.kernel.org,
	Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
	Felix Fietkau <nbd@nbd.name>,
	Jan Viktorin <jan.viktorin@gmail.com>
Subject: Re: [PATCH 4.20, 5.0] mt76x02u: use usb_bulk_msg to upload firmware
Date: Mon, 1 Apr 2019 13:50:10 +0200	[thread overview]
Message-ID: <20190401115010.GG8156@kroah.com> (raw)
In-Reply-To: <20190328132932.GA16543@redhat.com>

On Thu, Mar 28, 2019 at 02:29:39PM +0100, Stanislaw Gruszka wrote:
> commit 5de4db8fcb6d6fc7d9064c22841211790c0ab81b upstream.
> 
> We don't need to send firmware data asynchronously, much simpler is just
> use synchronous usb_bulk_msg().
> 
> [ stable note: this patch was originally developed as cleanup, but it
> remove incorrect usage of page_frag_alloc(): alloc more than PAGE_SIZE
> and create not ARCH_DMA_MINALIGN dma buffers needed at least for
> performance reason. Was tested on 5.0 and 4.20, see
> https://bugzilla.kernel.org/show_bug.cgi?id=202673 and
> https://bugzilla.kernel.org/show_bug.cgi?id=202241 ]
> 
> Tested-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt76.h          | 13 ++++++
>  .../net/wireless/mediatek/mt76/mt76x02_usb_mcu.c   | 52 +++++++---------------
>  drivers/net/wireless/mediatek/mt76/usb.c           |  1 -
>  3 files changed, 29 insertions(+), 37 deletions(-)

4.20 is now end-of-life, but I have queued this up for 5.0.y, thanks!

greg k-h

      reply	other threads:[~2019-04-01 11:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 13:29 [PATCH 4.20, 5.0] mt76x02u: use usb_bulk_msg to upload firmware Stanislaw Gruszka
2019-04-01 11:50 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401115010.GG8156@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jan.viktorin@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    --cc=sgruszka@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.