All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 4/6] configs: exynos: Add new CONFIG_SYS_ODROID_USB config option
Date: Mon,  1 Apr 2019 11:52:30 +0000	[thread overview]
Message-ID: <20190401115232.453-5-linux.amoon@gmail.com> (raw)
In-Reply-To: <20190401115232.453-1-linux.amoon@gmail.com>

Add new CONFIG_SYS_ODROID_USB flag to avoid compliation
error on other development boards.

Fix below compilation error:
Error: You must add new CONFIG options using Kconfig
The following new ad-hoc CONFIG options were detected:
CONFIG_SYS_ODROID_USB

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 board/samsung/odroid/Kconfig   | 3 +++
 drivers/usb/host/ehci-exynos.c | 6 ++++++
 include/configs/odroid.h       | 1 +
 3 files changed, 10 insertions(+)

diff --git a/board/samsung/odroid/Kconfig b/board/samsung/odroid/Kconfig
index 8b52a0d589..c5fbffabad 100644
--- a/board/samsung/odroid/Kconfig
+++ b/board/samsung/odroid/Kconfig
@@ -9,4 +9,7 @@ config SYS_VENDOR
 config SYS_CONFIG_NAME
 	default "odroid"
 
+config SYS_ODROID_USB
+	bool "Exynos4412 Odroid USB"
+
 endif
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index e6a542e092..3f62eba486 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -31,7 +31,9 @@ struct exynos_ehci_platdata {
 	struct gpio_desc vbus_gpio;
 };
 
+#ifdef CONFIG_SYS_ODROID_USB
 extern int exynos_usb_init(void);
+#endif
 
 /**
  * Contains pointers to register base addresses
@@ -145,6 +147,7 @@ static void exynos5_setup_usb_phy(struct exynos_usb_phy *usb)
 
 static int ehci_exynos_init_after_reset(struct ehci_ctrl *ehcntl)
 {
+#ifdef CONFIG_SYS_ODROID_USB
 	if (cpu_is_exynos4()) {
 		if (proid_is_exynos4412()) {
 			/*
@@ -153,6 +156,7 @@ static int ehci_exynos_init_after_reset(struct ehci_ctrl *ehcntl)
 			exynos_usb_init();
 		}
 	}
+#endif
 	return 0;
 }
 
@@ -172,10 +176,12 @@ static void exynos4412_setup_usb_phy(struct exynos4412_usb_phy *usb)
 	udelay(10);
 	clrbits_le32(&usb->usbphyrstcon, (RSTCON_HOSTPHY_SWRST | RSTCON_SWRST));
 
+#ifdef CONFIG_SYS_ODROID_USB
 	/*
 	 * "usb start" initialize the usb driver
 	 */
 	exynos_usb_init();
+#endif
 }
 
 static void setup_usb_phy(struct exynos_usb_phy *usb)
diff --git a/include/configs/odroid.h b/include/configs/odroid.h
index 9f2d43e3fa..d8d30c0f62 100644
--- a/include/configs/odroid.h
+++ b/include/configs/odroid.h
@@ -32,6 +32,7 @@
 #define CONFIG_SYS_MEMTEST_START	CONFIG_SYS_SDRAM_BASE
 #define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + 0x5E00000)
 #define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x3E00000)
+#define CONFIG_SYS_ODROID_USB
 
 #include <linux/sizes.h>
 
-- 
2.21.0

  parent reply	other threads:[~2019-04-01 11:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 11:52 [U-Boot] [RFC 0/6] Odroid U3 usb initialization Anand Moon
2019-04-01 11:52 ` [U-Boot] [RFC 1/6] odroid: exynos: USB initialization on the U3/X2 Anand Moon
2019-04-01 12:48   ` Krzysztof Kozlowski
2019-04-01 16:20     ` Anand Moon
2019-04-01 12:57   ` Lukasz Majewski
2019-04-01 13:22     ` Jack Mitchell
2019-04-03 19:58   ` Tobias Jakobi
2019-04-04  3:01     ` Anand Moon
2019-04-01 11:52 ` [U-Boot] [RFC 2/6] odroid: exynos: usb clean up for U3/X2 Anand Moon
2019-04-01 12:51   ` Krzysztof Kozlowski
2019-04-01 15:57     ` Anand Moon
2019-04-01 16:12       ` Krzysztof Kozlowski
2019-04-01 11:52 ` [U-Boot] [RFC 3/6] usb: exynos: add init_after_reset for usb reset Anand Moon
2019-04-01 12:55   ` Krzysztof Kozlowski
2019-04-01 16:05     ` Anand Moon
2019-04-01 16:14       ` Krzysztof Kozlowski
2019-04-01 11:52 ` Anand Moon [this message]
2019-04-01 12:57   ` [U-Boot] [RFC 4/6] configs: exynos: Add new CONFIG_SYS_ODROID_USB config option Krzysztof Kozlowski
2019-04-01 15:50     ` Anand Moon
2019-04-01 16:16       ` Krzysztof Kozlowski
2019-04-01 17:16         ` Anand Moon
2019-04-02  7:02           ` Krzysztof Kozlowski
2019-04-02  7:52             ` Anand Moon
2019-04-02  7:56               ` Krzysztof Kozlowski
2019-04-01 11:52 ` [U-Boot] [RFC 5/6] arm: exynos: odroid: fix the confict scripaddr extra env setting Anand Moon
2019-04-01 13:00   ` Krzysztof Kozlowski
2019-04-01 15:43     ` Anand Moon
2019-04-01 11:52 ` [U-Boot] [RFC 6/6] arm: exynos: add usbnet_devaddr setting to env Anand Moon
2019-04-01 13:04   ` Krzysztof Kozlowski
2019-04-01 16:42     ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401115232.453-5-linux.amoon@gmail.com \
    --to=linux.amoon@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.