From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: typec: Registering real device entries for the muxes From: Heikki Krogerus Message-Id: <20190401124022.GF9993@kuha.fi.intel.com> Date: Mon, 1 Apr 2019 15:40:22 +0300 To: Greg KH Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gTW9uLCBBcHIgMDEsIDIwMTkgYXQgMTI6MzQ6MjlQTSArMDIwMCwgR3JlZyBLSCB3cm90ZToK PiBPbiBNb24sIEFwciAwMSwgMjAxOSBhdCAwMToxNTo1M1BNICswMzAwLCBIZWlra2kgS3JvZ2Vy dXMgd3JvdGU6Cj4gPiBSZWdpc3RlcmluZyByZWFsIGRldmljZSBlbnRyaWVzIChzdHJ1Y3QgZGV2 aWNlKSBmb3IgdGhlIG1vZGUKPiA+IG11eGVzIGFzIHdlbGwgYXMgZm9yIHRoZSBvcmllbnRhdGlv biBzd2l0Y2hlcy4KPiA+IAo+ID4gVGhlIFR5cGUtQyBtdXggY29kZSB3YXMgZGVsaWJlcmF0ZWx5 IGF0dGVtcHRpbmcgdG8gYXZvaWQKPiA+IGNyZWF0aW9uIG9mIHNlcGFyYXRlIGRldmljZSBlbnRy aWVzIGZvciB0aGUgb3JpZW50YXRpb24KPiA+IHN3aXRjaCBhbmQgdGhlIG1vZGUgc3dpdGNoIChh bHRlcm5hdGUgbW9kZXMpIGJlY2F1c2UgdGhleQo+ID4gYXJlIG5vdCBwaHlzaWNhbCBkZXZpY2Vz LiBUaGV5IGFyZSBmdW5jdGlvbnMgb2YgYSBzaW5nbGUKPiA+IHBoeXNpY2FsIG11bHRpcGxleGVy L2RlbXVsdGlwbGV4ZXIgc3dpdGNoIGRldmljZS4KPiA+IAo+ID4gVW5mb3J0dW5hdGVseSBiZWNh dXNlIG9mIHRoZSBkZXBlbmRlbmN5IHdlIHN0aWxsIGhhdmUgb24gdGhlCj4gPiB1bmRlcmx5aW5n IG11eCBkZXZpY2UgZHJpdmVyLCB3ZSBoYWQgdG8gcHV0IGluIGhhY2tzIGxpa2UKPiA+IHRoZSBv bmUgaW4gdGhlIGNvbW1pdCAzZTNiODE5NjVjYmYgKCJ1c2I6IHR5cGVjOiBtdXg6IFRha2UKPiA+ IGNhcmUgb2YgZHJpdmVyIG1vZHVsZSByZWZlcmVuY2UgY291bnRpbmciKSB0byBtYWtlIHN1cmUg dGhlCj4gPiBkcml2ZXIgZG9lcyBub3QgZGlzYXBwZWFyIGZyb20gdW5kZXJuZWF0aCB1cy4gRXZl biB3aXRoCj4gPiB0aG9zZSBoYWNrcyB3ZSB3ZXJlIHN0aWxsIGxlZnQgd2l0aCBhIHBvdGVudGlh bCBOVWxsIHBvaW50ZXIKPiA+IGRlcmVmZXJlbmNlIHNjZW5hcmlvLCBzbyBqdXN0IGNyZWF0aW5n IHRoZSBkZXZpY2UgZW50cmllcywKPiA+IGFuZCBsZXR0aW5nIHRoZSBjb3JlIHRha2UgY2FyZSBv ZiB0aGUgZGVwZW5kZW5jaWVzLiBObyBtb3JlCj4gPiBoYWNrcyBuZWVkZWQuCj4gPiAKPiA+IEZp eGVzOiAzZTNiODE5NjVjYmYgKCJ1c2I6IHR5cGVjOiBtdXg6IFRha2UgY2FyZSBvZiBkcml2ZXIg bW9kdWxlIHJlZmVyZW5jZSBjb3VudGluZyIpCj4gPiBDYzogdjQuMTkueCA8c3RhYmxlQHZnZXIu a2VybmVsLm9yZz4gIyB2NC4xOS54Kwo+ID4gU2lnbmVkLW9mZi1ieTogSGVpa2tpIEtyb2dlcnVz IDxoZWlra2kua3JvZ2VydXNAbGludXguaW50ZWwuY29tPgo+IAo+IFRoaXMgbG9va3MgZ29vZCB0 byBtZSwgbmljZSB3b3JrIQo+IAo+IEJ1dCwgaXQgd291bGQgYmUgbmljZSBpZiBzb21lb25lIHdo byBoYXMgdGhpcyBoYXJkd2FyZSBjYW4gdGVzdCBpdCB0bwo+IHZlcmlmeSBpdCBkb2VzIGFjdHVh bGx5IHdvcmsgOikKClRoaXMgYWxvbmUgZG9lcyBub3Qgd29yayBvbiBJbnRlbCBDaGVycnl0cmFp bCBwbGF0Zm9ybXMuIEkgbmVlZCB0byBtYWtlCnRoZSBJbnRlbCBDaGVycnl0cmFpbCBNRkQgZHJp dmVyIChpbnRlbF9jaHRfaW50MzNmZS5jKSB0byB1c2UgdGhlIG5ldwpkZXZpY2UgbmFtZXMgdGhh dCB3ZSBub3cgaGF2ZSBmb3IgdGhlIG11eGVzLiBTb3JyeSBmb3IgdGhlIG1pc3Rha2UuCgpJJ2xs IHJlc2VuZCB0aGlzIGFuZCBpbmNsdWRlIHRoZSBuZWVkZWQgbW9kaWZpY2F0aW9ucyB0bwppbnRl bF9jaHRfaW50MzNmZS5jLiBIYW5zIHNob3VsZCBiZSBhYmxlIHRvIHRlc3QgdGhpcyBvbmNlIEkg ZG8gdGhhdC4gSQpob3BlIGhlIGhhcyB0aW1lLgoKCnRoYW5rcywK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A371C43381 for ; Mon, 1 Apr 2019 12:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCA3620870 for ; Mon, 1 Apr 2019 12:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726834AbfDAMk0 (ORCPT ); Mon, 1 Apr 2019 08:40:26 -0400 Received: from mga07.intel.com ([134.134.136.100]:29176 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbfDAMk0 (ORCPT ); Mon, 1 Apr 2019 08:40:26 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 05:40:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,296,1549958400"; d="scan'208";a="160274536" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 01 Apr 2019 05:40:23 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 01 Apr 2019 15:40:22 +0300 Date: Mon, 1 Apr 2019 15:40:22 +0300 From: Heikki Krogerus To: Greg KH Cc: Hans de Goede , linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] usb: typec: Registering real device entries for the muxes Message-ID: <20190401124022.GF9993@kuha.fi.intel.com> References: <20190401101553.45680-1-heikki.krogerus@linux.intel.com> <20190401103429.GA12128@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190401103429.GA12128@kroah.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 01, 2019 at 12:34:29PM +0200, Greg KH wrote: > On Mon, Apr 01, 2019 at 01:15:53PM +0300, Heikki Krogerus wrote: > > Registering real device entries (struct device) for the mode > > muxes as well as for the orientation switches. > > > > The Type-C mux code was deliberately attempting to avoid > > creation of separate device entries for the orientation > > switch and the mode switch (alternate modes) because they > > are not physical devices. They are functions of a single > > physical multiplexer/demultiplexer switch device. > > > > Unfortunately because of the dependency we still have on the > > underlying mux device driver, we had to put in hacks like > > the one in the commit 3e3b81965cbf ("usb: typec: mux: Take > > care of driver module reference counting") to make sure the > > driver does not disappear from underneath us. Even with > > those hacks we were still left with a potential NUll pointer > > dereference scenario, so just creating the device entries, > > and letting the core take care of the dependencies. No more > > hacks needed. > > > > Fixes: 3e3b81965cbf ("usb: typec: mux: Take care of driver module reference counting") > > Cc: v4.19.x # v4.19.x+ > > Signed-off-by: Heikki Krogerus > > This looks good to me, nice work! > > But, it would be nice if someone who has this hardware can test it to > verify it does actually work :) This alone does not work on Intel Cherrytrail platforms. I need to make the Intel Cherrytrail MFD driver (intel_cht_int33fe.c) to use the new device names that we now have for the muxes. Sorry for the mistake. I'll resend this and include the needed modifications to intel_cht_int33fe.c. Hans should be able to test this once I do that. I hope he has time. thanks, -- heikki