From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Anson Huang <anson.huang@nxp.com>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] rtc: snvs: use dev_pm_set_wake_irq() to simplify code
Date: Mon, 1 Apr 2019 17:28:36 +0200 [thread overview]
Message-ID: <20190401152836.GN3430@piout.net> (raw)
In-Reply-To: <1553667192-16665-1-git-send-email-Anson.Huang@nxp.com>
On 27/03/2019 06:18:20+0000, Anson Huang wrote:
> With calling dev_pm_set_wake_irq() to set SNVS RTC as wakeup
> source for suspend, generic wake irq mechanism will automatically
> enable it as wakeup source when suspend, then the suspend/resume
> callback which are ONLY for enabling/disabling irq wake can be
> removed, it simplifies the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/rtc/rtc-snvs.c | 25 ++++---------------------
> 1 file changed, 4 insertions(+), 21 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-04-01 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 6:18 [PATCH] rtc: snvs: use dev_pm_set_wake_irq() to simplify code Anson Huang
2019-04-01 15:28 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401152836.GN3430@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=anson.huang@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.