From: Greg KH <greg@kroah.com>
To: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/9] staging: rtl8723bs: os_dep: ioctl_linux.c: Fix indentation issue.
Date: Mon, 1 Apr 2019 19:24:43 +0200 [thread overview]
Message-ID: <20190401172443.GA16636@kroah.com> (raw)
In-Reply-To: <c1a8790575615dcf3af1fc5bb75092c3f93a3c68.1554028003.git.payal.s.kshirsagar.98@gmail.com>
On Sun, Mar 31, 2019 at 04:18:36PM +0530, Payal Kshirsagar wrote:
> To fix the indentation issue remove spaces and add tabs.
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 85 +++++++++++++-------------
> 1 file changed, 41 insertions(+), 44 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index ec336a5..e6f24b8 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -939,30 +939,30 @@ static int rtw_wx_get_mode(struct net_device *dev, struct iw_request_info *a,
>
>
> static int rtw_wx_set_pmkid(struct net_device *dev,
> - struct iw_request_info *a,
> - union iwreq_data *wrqu, char *extra)
> + struct iw_request_info *a,
> + union iwreq_data *wrqu, char *extra)
> {
> struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
> - u8 j, blInserted = false;
> - int intReturn = false;
> + u8 j, blInserted = false;
> + int intReturn = false;
> struct security_priv *psecuritypriv = &padapter->securitypriv;
> - struct iw_pmksa* pPMK = (struct iw_pmksa*)extra;
> - u8 strZeroMacAddress[ ETH_ALEN ] = { 0x00 };
> - u8 strIssueBssid[ ETH_ALEN ] = { 0x00 };
> + struct iw_pmksa* pPMK = (struct iw_pmksa*)extra;
> + u8 strZeroMacAddress[ ETH_ALEN ] = { 0x00 };
> + u8 strIssueBssid[ ETH_ALEN ] = { 0x00 };
>
> /*
> - There are the BSSID information in the bssid.sa_data array.
> - If cmd is IW_PMKSA_FLUSH, it means the wpa_suppplicant wants to clear all the PMKID information.
> - If cmd is IW_PMKSA_ADD, it means the wpa_supplicant wants to add a PMKID/BSSID to driver.
> - If cmd is IW_PMKSA_REMOVE, it means the wpa_supplicant wants to remove a PMKID/BSSID from driver.
> - */
> + There are the BSSID information in the bssid.sa_data array.
> + If cmd is IW_PMKSA_FLUSH, it means the wpa_suppplicant wants to clear all the PMKID information.
> + If cmd is IW_PMKSA_ADD, it means the wpa_supplicant wants to add a PMKID/BSSID to driver.
> + If cmd is IW_PMKSA_REMOVE, it means the wpa_supplicant wants to remove a PMKID/BSSID from driver.
> + */
That is not the correct indentation to make :(
next prev parent reply other threads:[~2019-04-01 17:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 10:48 [Outreachy kernel] [PATCH v2 0/9] staging: rtl8723bs: os_dep: ioctl_linux.c: Fix formatting issues Payal Kshirsagar
2019-03-31 10:48 ` [Outreachy kernel] [PATCH v2 1/9] staging: rtl8723bs: os_dep: ioctl_linux.c: Fix indentation issue Payal Kshirsagar
2019-04-01 17:24 ` Greg KH [this message]
2019-03-31 10:48 ` [Outreachy kernel] [PATCH v2 2/9] staging: rtl8723bs: os_dep: ioctl_linux.c: space prohibited before square brackets Payal Kshirsagar
2019-03-31 10:48 ` [Outreachy kernel] [PATCH v2 3/9] staging: rtl8723bs: os_dep: ioctl_linux.c: "foo* bar" should be "foo *bar" Payal Kshirsagar
2019-03-31 10:48 ` [Outreachy kernel] [PATCH v2 4/9] staging: rtl8723bs: os_dep: ioctl_linux.c: "(foo*)" should be "(foo *)" Payal Kshirsagar
2019-03-31 10:48 ` [Outreachy kernel] [PATCH v2 5/9] staging: rtl8723bs: os_dep: ioctl_linux.c: Avoid CamelCase "blInserted" Payal Kshirsagar
2019-03-31 10:48 ` [Outreachy kernel] [PATCH v2 6/9] staging: rtl8723bs: os_dep: ioctl_linux.c: Avoid CamelCase "intReturn" Payal Kshirsagar
2019-03-31 10:48 ` [Outreachy kernel] [PATCH v2 7/9] staging: rtl8723bs: os_dep: ioctl_linux.c: space prohibited before semicolon Payal Kshirsagar
2019-03-31 10:48 ` [Outreachy kernel] [PATCH v2 8/9] staging: rtl8723bs: os_dep: ioctl_linux.c: Avoid CamelCase "pPMK" Payal Kshirsagar
2019-03-31 10:48 ` [Outreachy kernel] [PATCH v2 9/9] staging: rtl8723bs: os_dep: ioctl_linux.c: Alignment should match open parenthesis Payal Kshirsagar
2019-04-01 17:25 ` [Outreachy kernel] [PATCH v2 0/9] staging: rtl8723bs: os_dep: ioctl_linux.c: Fix formatting issues Greg KH
2019-04-02 4:46 ` Payal Kshirsagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401172443.GA16636@kroah.com \
--to=greg@kroah.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=payal.s.kshirsagar.98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.