From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: musb: Force-disable pullup on shutdown From: Bin Liu Message-Id: <20190401182008.GL25852@uda0271908> Date: Mon, 1 Apr 2019 13:20:08 -0500 To: Paul Cercueil Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me List-ID: T24gTW9uLCBBcHIgMDEsIDIwMTkgYXQgMDc6NDY6MjJQTSArMDIwMCwgUGF1bCBDZXJjdWVpbCB3 cm90ZToKPiAKPiAKPiBMZSBsdW4uIDEgYXZyaWwgMjAxOSDDoCAxOToxNywgQmluIExpdSA8Yi1s aXVAdGkuY29tPiBhIMOpY3JpdCA6Cj4gPk9uIFRodSwgTWFyIDIxLCAyMDE5IGF0IDAzOjQyOjQ2 UE0gKzAxMDAsIFBhdWwgQ2VyY3VlaWwgd3JvdGU6Cj4gPj4gV2hlbiB0aGUgbXVzYiBpcyBzaHV0 ZG93biwgZm9yIGluc3RhbmNlIHdoZW4gdGhlIGRyaXZlciBpcyB1bmxvYWRlZCwKPiA+PiBmb3Jj ZS1kaXNhYmxlIHRoZSBwdWxsdXAuIE90aGVyd2lzZSwgdGhlIGhvc3Qgd2lsbCBzdGlsbCBzZWUK PiA+PnRoZSBnYWRnZXQKPiA+PiBkZXZpY2UgZXZlbiBhZnRlciB0aGUgc2h1dGRvd24uCj4gPgo+ ID5ob3cgd291bGQgdGhpcyBoYXBwZW4/Cj4gPgo+ID53aGVuIG11c2ItaGRyYyBkcml2ZXIgaXMg dW5sb2FkZWQsIHVkYyBjb3JlIHJlbW92ZXMgdGhlIGJvdW5kIGdhZGdldAo+ID5kcml2ZXIgd2hp Y2ggY2FsbHMgbXVzYl9nYWRnZXRfcHVsbHVwKCkgdG8gZGlzYWJsZSB0aGUgcHVsbHVwLgo+IAo+ IEknbSB0ZXN0aW5nIHdpdGggdGhlIGp6NDc0MC1tdXNiIGRyaXZlci4gSSBkb24ndCB1bmxvYWQg dGhlIG1vZHVsZSAoaXQncwo+IGJ1aWx0LWluKSBidXQgdW5iaW5kIGl0IGZyb20gc3lzZnMuCgpJ IGRpZCB1bmJpbmQgdG9vLgoKcm9vdEBhbTMzNXgtZXZtOi9zeXMvYnVzL3BsYXRmb3JtL2RyaXZl cnMvbXVzYi1oZHJjIyBlY2hvIG11c2ItaGRyYy4wID4gdW5iaW5kCgpvciB1bmJpbmQgdGhlIGds dWUgZHJpdmVyOgoKcm9vdEBhbTMzNXgtZXZtOi9zeXMvYnVzL3BsYXRmb3JtL2RyaXZlcnMvbXVz Yi1kc3BzIyBlY2hvIDQ3NDAxNDAwLnVzYiA+IHVuYmluZAoKbXVzYl9nYWRnZXRfcHVsbHVwKCkg aXMgY2FsbGVkIGluIGJvdGggY2FzZXMuCgpbIDM4ODAuNTk3MDE0XSBbPGJmNDQ0YWIwPl0gKG11 c2JfZ2FkZ2V0X3B1bGx1cCBbbXVzYl9oZHJjXSkgZnJvbSBbPGJmNDAyY2JjPl0gKHVzYl9nYWRn ZXRfZGlzY29ubmVjdCsweDNjLzB4ZjQgW3VkY19jb3JlXSkKWyAzODgwLjYwNzk1OV0gWzxiZjQw MmNiYz5dICh1c2JfZ2FkZ2V0X2Rpc2Nvbm5lY3QgW3VkY19jb3JlXSkgZnJvbSBbPGJmNDAzYjI4 Pl0gKHVzYl9nYWRnZXRfcmVtb3ZlX2RyaXZlcisweDRjLzB4OTAgW3VkY19jb3JlXSkKWyAzODgw LjYxOTMzOF0gWzxiZjQwM2IyOD5dICh1c2JfZ2FkZ2V0X3JlbW92ZV9kcml2ZXIgW3VkY19jb3Jl XSkgZnJvbSBbPGJmNDAzZDIwPl0gKHVzYl9kZWxfZ2FkZ2V0X3VkYysweDVjLzB4YzAgW3VkY19j b3JlXSkKWyAzODgwLjYzMDQ3MV0gWzxiZjQwM2QyMD5dICh1c2JfZGVsX2dhZGdldF91ZGMgW3Vk Y19jb3JlXSkgZnJvbSBbPGJmNDM5ZmY4Pl0gKG11c2JfcmVtb3ZlKzB4NTAvMHgxMzQgW211c2Jf aGRyY10pClsgMzg4MC42NDA2NDhdIFs8YmY0MzlmZjg+XSAobXVzYl9yZW1vdmUgW211c2JfaGRy Y10pIGZyb20gWzxjMDU2NjhjYz5dIChwbGF0Zm9ybV9kcnZfcmVtb3ZlKzB4MjgvMHg0OCkKWyAz ODgwLjY0OTgzMV0gWzxjMDU2NjhjYz5dIChwbGF0Zm9ybV9kcnZfcmVtb3ZlKSBmcm9tIFs8YzA1 NjRlM2M+XSAoZGV2aWNlX3JlbGVhc2VfZHJpdmVyX2ludGVybmFsKzB4ZTQvMHgxYjQpClsgMzg4 MC42NTk3MDhdIFs8YzA1NjRlM2M+XSAoZGV2aWNlX3JlbGVhc2VfZHJpdmVyX2ludGVybmFsKSBm cm9tIFs8YzA1NjMzZTQ+XSAoYnVzX3JlbW92ZV9kZXZpY2UrMHhlMC8weDE0MCkKWyAzODgwLjY2 OTQwOV0gWzxjMDU2MzNlND5dIChidXNfcmVtb3ZlX2RldmljZSkgZnJvbSBbPGMwNTVmMzU4Pl0g KGRldmljZV9kZWwrMHgxNDAvMHgzNzQpClsgMzg4MC42Nzc0NTVdIFs8YzA1NWYzNTg+XSAoZGV2 aWNlX2RlbCkgZnJvbSBbPGMwNTY2ZmYwPl0gKHBsYXRmb3JtX2RldmljZV9kZWwucGFydC4zKzB4 MTgvMHg4MCkKWyAzODgwLjY4NjExMF0gWzxjMDU2NmZmMD5dIChwbGF0Zm9ybV9kZXZpY2VfZGVs LnBhcnQuMykgZnJvbSBbPGMwNTY3MDk4Pl0gKHBsYXRmb3JtX2RldmljZV91bnJlZ2lzdGVyKzB4 MjQvMHgzMCkKWyAzODgwLjY5NjE3MF0gWzxjMDU2NzA5OD5dIChwbGF0Zm9ybV9kZXZpY2VfdW5y ZWdpc3RlcikgZnJvbSBbPGJmNDhjM2UwPl0gKGRzcHNfcmVtb3ZlKzB4MWMvMHgzOCBbbXVzYl9k c3BzXSkKWyAzODgwLjcwNjAxMF0gWzxiZjQ4YzNlMD5dIChkc3BzX3JlbW92ZSBbbXVzYl9kc3Bz XSkgZnJvbSBbPGMwNTY2OGNjPl0gKHBsYXRmb3JtX2Rydl9yZW1vdmUrMHgyOC8weDQ4KQpbIDM4 ODAuNzE1MTkwXSBbPGMwNTY2OGNjPl0gKHBsYXRmb3JtX2Rydl9yZW1vdmUpIGZyb20gWzxjMDU2 NGUzYz5dIChkZXZpY2VfcmVsZWFzZV9kcml2ZXJfaW50ZXJuYWwrMHhlNC8weDFiNCkKWyAzODgw LjcyNTA2NV0gWzxjMDU2NGUzYz5dIChkZXZpY2VfcmVsZWFzZV9kcml2ZXJfaW50ZXJuYWwpIGZy b20gWzxjMDU2MmIyYz5dICh1bmJpbmRfc3RvcmUrMHg2NC8weGQ4KQpbIDM4ODAuNzM0MjUzXSBb PGMwNTYyYjJjPl0gKHVuYmluZF9zdG9yZSkgZnJvbSBbPGMwMzUwYzU4Pl0gKGtlcm5mc19mb3Bf d3JpdGUrMHhmNC8weDFjYykKClJlZ2FyZHMsCi1CaW4uCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E294C43381 for ; Mon, 1 Apr 2019 18:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFB3D20883 for ; Mon, 1 Apr 2019 18:20:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RcLnIFoM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728984AbfDASUO (ORCPT ); Mon, 1 Apr 2019 14:20:14 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:39606 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728670AbfDASUO (ORCPT ); Mon, 1 Apr 2019 14:20:14 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x31IK9O5011727; Mon, 1 Apr 2019 13:20:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1554142809; bh=hKLKhAj1bb69DV25Byjd5WkAHfiQxIydUOjBsP+D5yE=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=RcLnIFoMJL5iuG5m+Y/pv149AbYi9ngvSCwzLAIycxNCTaQ7IAP2MA0WQlozH/4Va 9wAnMxZHxGtxwiWhnwuHT/dhSZkKt/0NuRSfY0IRmgmGIJMxuPYHZjxXXm/qMOA9UU WGhEviQrTbSsZzvSlR2RyzbP21aIhBTzGvreBTTE= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x31IK9hJ041243 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 1 Apr 2019 13:20:09 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 1 Apr 2019 13:20:08 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 1 Apr 2019 13:20:08 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x31IK85n048717; Mon, 1 Apr 2019 13:20:08 -0500 Date: Mon, 1 Apr 2019 13:20:08 -0500 From: Bin Liu To: Paul Cercueil CC: , , Subject: Re: [PATCH] usb: musb: Force-disable pullup on shutdown Message-ID: <20190401182008.GL25852@uda0271908> Mail-Followup-To: Bin Liu , Paul Cercueil , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me References: <20190321144246.3547-1-paul@crapouillou.net> <20190401171725.GK25852@uda0271908> <1554140782.10471.0@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1554140782.10471.0@crapouillou.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 01, 2019 at 07:46:22PM +0200, Paul Cercueil wrote: > > > Le lun. 1 avril 2019 à 19:17, Bin Liu a écrit : > >On Thu, Mar 21, 2019 at 03:42:46PM +0100, Paul Cercueil wrote: > >> When the musb is shutdown, for instance when the driver is unloaded, > >> force-disable the pullup. Otherwise, the host will still see > >>the gadget > >> device even after the shutdown. > > > >how would this happen? > > > >when musb-hdrc driver is unloaded, udc core removes the bound gadget > >driver which calls musb_gadget_pullup() to disable the pullup. > > I'm testing with the jz4740-musb driver. I don't unload the module (it's > built-in) but unbind it from sysfs. I did unbind too. root@am335x-evm:/sys/bus/platform/drivers/musb-hdrc# echo musb-hdrc.0 > unbind or unbind the glue driver: root@am335x-evm:/sys/bus/platform/drivers/musb-dsps# echo 47401400.usb > unbind musb_gadget_pullup() is called in both cases. [ 3880.597014] [] (musb_gadget_pullup [musb_hdrc]) from [] (usb_gadget_disconnect+0x3c/0xf4 [udc_core]) [ 3880.607959] [] (usb_gadget_disconnect [udc_core]) from [] (usb_gadget_remove_driver+0x4c/0x90 [udc_core]) [ 3880.619338] [] (usb_gadget_remove_driver [udc_core]) from [] (usb_del_gadget_udc+0x5c/0xc0 [udc_core]) [ 3880.630471] [] (usb_del_gadget_udc [udc_core]) from [] (musb_remove+0x50/0x134 [musb_hdrc]) [ 3880.640648] [] (musb_remove [musb_hdrc]) from [] (platform_drv_remove+0x28/0x48) [ 3880.649831] [] (platform_drv_remove) from [] (device_release_driver_internal+0xe4/0x1b4) [ 3880.659708] [] (device_release_driver_internal) from [] (bus_remove_device+0xe0/0x140) [ 3880.669409] [] (bus_remove_device) from [] (device_del+0x140/0x374) [ 3880.677455] [] (device_del) from [] (platform_device_del.part.3+0x18/0x80) [ 3880.686110] [] (platform_device_del.part.3) from [] (platform_device_unregister+0x24/0x30) [ 3880.696170] [] (platform_device_unregister) from [] (dsps_remove+0x1c/0x38 [musb_dsps]) [ 3880.706010] [] (dsps_remove [musb_dsps]) from [] (platform_drv_remove+0x28/0x48) [ 3880.715190] [] (platform_drv_remove) from [] (device_release_driver_internal+0xe4/0x1b4) [ 3880.725065] [] (device_release_driver_internal) from [] (unbind_store+0x64/0xd8) [ 3880.734253] [] (unbind_store) from [] (kernfs_fop_write+0xf4/0x1cc) Regards, -Bin.