From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: musb: Silence error about blacklisting hubs if !CONFIG_USB From: Bin Liu Message-Id: <20190401183442.GM25852@uda0271908> Date: Mon, 1 Apr 2019 13:34:42 -0500 To: Paul Cercueil Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gTW9uLCBBcHIgMDEsIDIwMTkgYXQgMDc6NTE6NTlQTSArMDIwMCwgUGF1bCBDZXJjdWVpbCB3 cm90ZToKPiAKPiAKPiBMZSBsdW4uIDEgYXZyaWwgMjAxOSDDoCAxNzo0MywgQmluIExpdSA8Yi1s aXVAdGkuY29tPiBhIMOpY3JpdCA6Cj4gPk9uIFR1ZSwgTWFyIDE5LCAyMDE5IGF0IDAyOjUxOjQ2 UE0gKzAxMDAsIFBhdWwgQ2VyY3VlaWwgd3JvdGU6Cj4gPj4gU29tZSBkcml2ZXJzLCBsaWtlIGp6 NDc0MC1tdXNiLCBkb24ndCBkZXBlbmQgb24gQ09ORklHX1VTQi4KPiA+Cj4gPkNPTkZJR19VU0Jf T1RHX0JMQUNLTElTVF9IVUIgaXMgYWJvdXQgaHViLCBzbyBzaG91bGQgaXQgZGVwZW5kIG9uCj4g PkNPTkZJR19VU0IgaW5zdGVhZCBpbiBkcml2ZXJzL3VzYi9jb3JlL0tjb25maWc/Cj4gCj4gSXQn cyBhbHJlYWR5IHRoZSBjYXNlLCBpbmRpcmVjdGx5IC0gaXQgZGVwZW5kcyBvbiBDT05GSUdfVVNC X09URywKPiB3aGljaCBvbmx5IGV4aXN0cyBpZiBDT05GSUdfVVNCIGlzIHNldC4KCk5ldmVyIG1p bmQsIG15IGJhZCwgSSBtaXN1bmRlcnN0b29kIHRoZSBsb2dpYy4KCj4gPj4KPiA+PiBTaWduZWQt b2ZmLWJ5OiBQYXVsIENlcmN1ZWlsIDxwYXVsQGNyYXBvdWlsbG91Lm5ldD4KPiA+PiAtLS0KPiA+ PiAgZHJpdmVycy91c2IvbXVzYi9tdXNiX2NvcmUuYyB8IDkgKysrKystLS0tCj4gPj4gIDEgZmls ZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy91c2IvbXVzYi9tdXNiX2NvcmUuYwo+ID4+Yi9kcml2ZXJzL3VzYi9t dXNiL211c2JfY29yZS5jCj4gPj4gaW5kZXggYjdkNTYyNzJmOWQxLi45ZjVhNDgxOWE3NDQgMTAw NjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy91c2IvbXVzYi9tdXNiX2NvcmUuYwo+ID4+ICsrKyBiL2Ry aXZlcnMvdXNiL211c2IvbXVzYl9jb3JlLmMKPiA+PiBAQCAtMTQ5NywxMCArMTQ5NywxMSBAQCBz dGF0aWMgaW50IG11c2JfY29yZV9pbml0KHUxNgo+ID4+bXVzYl90eXBlLCBzdHJ1Y3QgbXVzYiAq bXVzYikKPiA+PiAgCX0gZWxzZSB7Cj4gPj4gIAkJbXVzYi0+aXNfbXVsdGlwb2ludCA9IDA7Cj4g Pj4gIAkJdHlwZSA9ICIiOwo+ID4+IC0jaWZuZGVmCUNPTkZJR19VU0JfT1RHX0JMQUNLTElTVF9I VUIKPiA+PiAtCQlwcl9lcnIoIiVzOiBrZXJuZWwgbXVzdCBibGFja2xpc3QgZXh0ZXJuYWwgaHVi c1xuIiwKPiA+PiAtCQkgICAgICAgbXVzYl9kcml2ZXJfbmFtZSk7Cj4gPj4gLSNlbmRpZgo+ID4+ ICsJCWlmIChJU19FTkFCTEVEKENPTkZJR19VU0IpICYmCj4gPj4gKwkJICAgICFJU19FTkFCTEVE KENPTkZJR19VU0JfT1RHX0JMQUNLTElTVF9IVUIpKSB7Cj4gPj4gKwkJCXByX2VycigiJXM6IGtl cm5lbCBtdXN0IGJsYWNrbGlzdCBleHRlcm5hbCBodWJzXG4iLAo+ID4+ICsJCQkgICAgICAgbXVz Yl9kcml2ZXJfbmFtZSk7Cj4gPj4gKwkJfQo+ID4+ICAJfQo+ID4+Cj4gPj4gIAkvKiBsb2cgcmVs ZWFzZSBpbmZvICovCgpUaGUgcGF0Y2ggaXMgYXBwbGllZC4KClRoYW5rcywKLUJpbi4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6132EC43381 for ; Mon, 1 Apr 2019 18:34:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FF72206DD for ; Mon, 1 Apr 2019 18:34:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="HtLX2uu4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728875AbfDASes (ORCPT ); Mon, 1 Apr 2019 14:34:48 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:41428 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728690AbfDASer (ORCPT ); Mon, 1 Apr 2019 14:34:47 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x31IYgKl016321; Mon, 1 Apr 2019 13:34:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1554143682; bh=0CF+Wt30WQRhwNj1PdNd4iu0m3tHVMrz/H7WnFT4LHI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=HtLX2uu4YPYTpCqR05nzbSnJkGsjDBsuR8gKak8dshGg1p6CgDCwE+ruY4XEpCX91 xVHy1Sm+0FxKXzLX2pb5TETP07cwWhfvJ8s6JyLiP+kCmNo7yhFbT0oxB/Or1QnDt/ DlBQqQqTGXbCLbtIM/15QUbFuMITqeyctJ6oXMgo= Received: from DFLE107.ent.ti.com (dfle107.ent.ti.com [10.64.6.28]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x31IYg3Y058565 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 1 Apr 2019 13:34:42 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 1 Apr 2019 13:34:42 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 1 Apr 2019 13:34:42 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x31IYgtn053754; Mon, 1 Apr 2019 13:34:42 -0500 Date: Mon, 1 Apr 2019 13:34:42 -0500 From: Bin Liu To: Paul Cercueil CC: , Subject: Re: [PATCH] usb: musb: Silence error about blacklisting hubs if !CONFIG_USB Message-ID: <20190401183442.GM25852@uda0271908> Mail-Followup-To: Bin Liu , Paul Cercueil , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190319135146.25995-1-paul@crapouillou.net> <20190401154333.GJ25852@uda0271908> <1554141119.10471.1@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1554141119.10471.1@crapouillou.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 01, 2019 at 07:51:59PM +0200, Paul Cercueil wrote: > > > Le lun. 1 avril 2019 à 17:43, Bin Liu a écrit : > >On Tue, Mar 19, 2019 at 02:51:46PM +0100, Paul Cercueil wrote: > >> Some drivers, like jz4740-musb, don't depend on CONFIG_USB. > > > >CONFIG_USB_OTG_BLACKLIST_HUB is about hub, so should it depend on > >CONFIG_USB instead in drivers/usb/core/Kconfig? > > It's already the case, indirectly - it depends on CONFIG_USB_OTG, > which only exists if CONFIG_USB is set. Never mind, my bad, I misunderstood the logic. > >> > >> Signed-off-by: Paul Cercueil > >> --- > >> drivers/usb/musb/musb_core.c | 9 +++++---- > >> 1 file changed, 5 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/usb/musb/musb_core.c > >>b/drivers/usb/musb/musb_core.c > >> index b7d56272f9d1..9f5a4819a744 100644 > >> --- a/drivers/usb/musb/musb_core.c > >> +++ b/drivers/usb/musb/musb_core.c > >> @@ -1497,10 +1497,11 @@ static int musb_core_init(u16 > >>musb_type, struct musb *musb) > >> } else { > >> musb->is_multipoint = 0; > >> type = ""; > >> -#ifndef CONFIG_USB_OTG_BLACKLIST_HUB > >> - pr_err("%s: kernel must blacklist external hubs\n", > >> - musb_driver_name); > >> -#endif > >> + if (IS_ENABLED(CONFIG_USB) && > >> + !IS_ENABLED(CONFIG_USB_OTG_BLACKLIST_HUB)) { > >> + pr_err("%s: kernel must blacklist external hubs\n", > >> + musb_driver_name); > >> + } > >> } > >> > >> /* log release info */ The patch is applied. Thanks, -Bin.