From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Matthew Garrett <matthewgarrett@google.com>, tomas.winkler@intel.com
Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca,
roberto.sassu@huawei.com, linux-efi@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, tweek@google.com
Subject: Re: Add support for TCG2 log format on UEFI systems
Date: Tue, 2 Apr 2019 02:52:45 +0300 [thread overview]
Message-ID: <20190401235245.GA29282@linux.intel.com> (raw)
In-Reply-To: <20190227202658.197113-1-matthewgarrett@google.com>
On Wed, Feb 27, 2019 at 12:26:54PM -0800, Matthew Garrett wrote:
> Identical to V4, but based on tpmdd-next
OK, so on my GLK NUC I get valid final log and invalid event log
after adding some extra klogs.
I.e.
- if (efi.tpm_log == EFI_INVALID_TABLE_ADDR)
+ if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) {
+ pr_err("No event log\n");
return -ENODEV;
+ }
will result
[ 2.654392] No event log
but still
[ 0.000000] efi: ACPI 2.0=0x69ca2000 ACPI=0x69ca2000 TPMFinalLog=0x69ce4000 SMBIOS=0x69f63000 SMBIOS 3.0=0x69f62000 ESRT=0x69f3e818 MEMATTR=0x63475118
Tomas, I wonder if you are able to get the log out with some machine?
/Jarkko
next prev parent reply other threads:[~2019-04-01 23:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 20:26 Add support for TCG2 log format on UEFI systems Matthew Garrett
2019-02-27 20:26 ` [PATCH V5 1/4] tpm: Abstract crypto agile event size calculations Matthew Garrett
2019-02-27 20:26 ` [PATCH V5 2/4] tpm: Reserve the TPM final events table Matthew Garrett
2019-04-30 13:07 ` Bartosz Szczepanek
2019-04-30 19:51 ` Matthew Garrett
2019-04-30 21:35 ` Matthew Garrett
2019-05-02 6:45 ` Bartosz Szczepanek
2019-05-02 18:07 ` Matthew Garrett
2019-05-06 19:20 ` Bartosz Szczepanek
2019-05-02 7:14 ` Ard Biesheuvel
2019-05-02 18:04 ` Matthew Garrett
2019-05-02 20:56 ` Ard Biesheuvel
2019-05-03 6:02 ` Ingo Molnar
2019-05-03 6:12 ` Jarkko Sakkinen
2019-05-03 5:51 ` Jarkko Sakkinen
2019-05-02 8:32 ` Jarkko Sakkinen
2019-05-02 18:03 ` Matthew Garrett
2019-05-03 5:49 ` Jarkko Sakkinen
2019-02-27 20:26 ` [PATCH V5 3/4] tpm: Append the final event log to the TPM event log Matthew Garrett
2019-02-27 20:26 ` [PATCH V5 4/4] efi: Attempt to get the TCG2 event log in the boot stub Matthew Garrett
2019-03-14 9:35 ` Add support for TCG2 log format on UEFI systems Jarkko Sakkinen
2019-03-14 21:04 ` Matthew Garrett
2019-03-15 11:47 ` Jarkko Sakkinen
2019-04-01 23:52 ` Jarkko Sakkinen [this message]
2019-04-02 3:32 ` Matthew Garrett
2019-04-02 13:07 ` Jarkko Sakkinen
2019-04-02 17:15 ` Matthew Garrett
2019-04-03 17:50 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190401235245.GA29282@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=peterhuewe@gmx.de \
--cc=roberto.sassu@huawei.com \
--cc=tomas.winkler@intel.com \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.