From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1
Date: Tue, 2 Apr 2019 09:05:55 +0800 [thread overview]
Message-ID: <20190402010553.GE21944@ming.t460p> (raw)
In-Reply-To: <20190401135509.GC23581@kroah.com>
On Mon, Apr 01, 2019@03:55:09PM +0200, Greg KH wrote:
> On Thu, Mar 28, 2019@08:55:06AM +0800, Ming Lei wrote:
> > On Wed, Mar 27, 2019@12:16:58PM -0400, Sasha Levin wrote:
> > > On Wed, Mar 27, 2019@05:02:30PM +0800, Ming Lei wrote:
> > > > NVMe target only accepts single-page sg list, either file or block
> > > > device backed target code follows this assumption.
> > > >
> > > > However, loop target is one exception, given the sg list is from
> > > > the host queue directly.
> > > >
> > > > This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1
> > > > for following NVMe target assumption.
> > > >
> > > > Reported-by: Yi Zhang <yi.zhang at redhat.com>
> > > > Fixes: 3a85a5de29ea ("nvme-loop: add a NVMe loopback host driver")
> > > > Cc: Yi Zhang <yi.zhang at redhat.com>
> > > > Cc: Sagi Grimberg <sagi at grimberg.me>
> > > > Cc: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
> > > > Cc: <stable at vger.kernel.org>
> > > > Signed-off-by: Ming Lei <ming.lei at redhat.com>
> > >
> > > Could you provide some background as to why this is -stable only in the
> > > commit message?
> >
> > Multi-page bvec has been merged to linus tree already, so the following
> > patch simply can fix the current issue without needing to limit the segment
> > size for nvme-loop:
> >
> > http://lists.infradead.org/pipermail/linux-nvme/2019-March/023105.html
>
> Can you resend the patch with this needed information in it? Also, I
> don't understand what you are referring to with that url, why can't we
> just use that patch?
Sure, will resend the patch with the above info soon.
Thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>, Yi Zhang <yi.zhang@redhat.com>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-nvme@lists.infradead.org, stable@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1
Date: Tue, 2 Apr 2019 09:05:55 +0800 [thread overview]
Message-ID: <20190402010553.GE21944@ming.t460p> (raw)
In-Reply-To: <20190401135509.GC23581@kroah.com>
On Mon, Apr 01, 2019 at 03:55:09PM +0200, Greg KH wrote:
> On Thu, Mar 28, 2019 at 08:55:06AM +0800, Ming Lei wrote:
> > On Wed, Mar 27, 2019 at 12:16:58PM -0400, Sasha Levin wrote:
> > > On Wed, Mar 27, 2019 at 05:02:30PM +0800, Ming Lei wrote:
> > > > NVMe target only accepts single-page sg list, either file or block
> > > > device backed target code follows this assumption.
> > > >
> > > > However, loop target is one exception, given the sg list is from
> > > > the host queue directly.
> > > >
> > > > This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1
> > > > for following NVMe target assumption.
> > > >
> > > > Reported-by: Yi Zhang <yi.zhang@redhat.com>
> > > > Fixes: 3a85a5de29ea ("nvme-loop: add a NVMe loopback host driver")
> > > > Cc: Yi Zhang <yi.zhang@redhat.com>
> > > > Cc: Sagi Grimberg <sagi@grimberg.me>
> > > > Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> > > > Cc: <stable@vger.kernel.org>
> > > > Signed-off-by: Ming Lei <ming.lei@redhat.com>
> > >
> > > Could you provide some background as to why this is -stable only in the
> > > commit message?
> >
> > Multi-page bvec has been merged to linus tree already, so the following
> > patch simply can fix the current issue without needing to limit the segment
> > size for nvme-loop:
> >
> > http://lists.infradead.org/pipermail/linux-nvme/2019-March/023105.html
>
> Can you resend the patch with this needed information in it? Also, I
> don't understand what you are referring to with that url, why can't we
> just use that patch?
Sure, will resend the patch with the above info soon.
Thanks,
Ming
next prev parent reply other threads:[~2019-04-02 1:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 9:02 [PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 Ming Lei
2019-03-27 9:02 ` Ming Lei
2019-03-27 16:16 ` Sasha Levin
2019-03-27 16:16 ` Sasha Levin
2019-03-28 0:55 ` Ming Lei
2019-03-28 0:55 ` Ming Lei
2019-04-01 13:55 ` Greg KH
2019-04-01 13:55 ` Greg KH
2019-04-02 1:05 ` Ming Lei [this message]
2019-04-02 1:05 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402010553.GE21944@ming.t460p \
--to=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.