From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: typec: Registering real device entries for the muxes From: Heikki Krogerus Message-Id: <20190402124747.GH9993@kuha.fi.intel.com> Date: Tue, 2 Apr 2019 15:47:47 +0300 To: Hans de Goede Cc: Greg KH , linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gTW9uLCBBcHIgMDEsIDIwMTkgYXQgMDI6NDU6MTFQTSArMDIwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBISSwKPiAKPiBPbiAwMS0wNC0xOSAxNDo0MCwgSGVpa2tpIEtyb2dlcnVzIHdyb3Rl Ogo+ID4gT24gTW9uLCBBcHIgMDEsIDIwMTkgYXQgMTI6MzQ6MjlQTSArMDIwMCwgR3JlZyBLSCB3 cm90ZToKPiA+ID4gT24gTW9uLCBBcHIgMDEsIDIwMTkgYXQgMDE6MTU6NTNQTSArMDMwMCwgSGVp a2tpIEtyb2dlcnVzIHdyb3RlOgo+ID4gPiA+IFJlZ2lzdGVyaW5nIHJlYWwgZGV2aWNlIGVudHJp ZXMgKHN0cnVjdCBkZXZpY2UpIGZvciB0aGUgbW9kZQo+ID4gPiA+IG11eGVzIGFzIHdlbGwgYXMg Zm9yIHRoZSBvcmllbnRhdGlvbiBzd2l0Y2hlcy4KPiA+ID4gPiAKPiA+ID4gPiBUaGUgVHlwZS1D IG11eCBjb2RlIHdhcyBkZWxpYmVyYXRlbHkgYXR0ZW1wdGluZyB0byBhdm9pZAo+ID4gPiA+IGNy ZWF0aW9uIG9mIHNlcGFyYXRlIGRldmljZSBlbnRyaWVzIGZvciB0aGUgb3JpZW50YXRpb24KPiA+ ID4gPiBzd2l0Y2ggYW5kIHRoZSBtb2RlIHN3aXRjaCAoYWx0ZXJuYXRlIG1vZGVzKSBiZWNhdXNl IHRoZXkKPiA+ID4gPiBhcmUgbm90IHBoeXNpY2FsIGRldmljZXMuIFRoZXkgYXJlIGZ1bmN0aW9u cyBvZiBhIHNpbmdsZQo+ID4gPiA+IHBoeXNpY2FsIG11bHRpcGxleGVyL2RlbXVsdGlwbGV4ZXIg c3dpdGNoIGRldmljZS4KPiA+ID4gPiAKPiA+ID4gPiBVbmZvcnR1bmF0ZWx5IGJlY2F1c2Ugb2Yg dGhlIGRlcGVuZGVuY3kgd2Ugc3RpbGwgaGF2ZSBvbiB0aGUKPiA+ID4gPiB1bmRlcmx5aW5nIG11 eCBkZXZpY2UgZHJpdmVyLCB3ZSBoYWQgdG8gcHV0IGluIGhhY2tzIGxpa2UKPiA+ID4gPiB0aGUg b25lIGluIHRoZSBjb21taXQgM2UzYjgxOTY1Y2JmICgidXNiOiB0eXBlYzogbXV4OiBUYWtlCj4g PiA+ID4gY2FyZSBvZiBkcml2ZXIgbW9kdWxlIHJlZmVyZW5jZSBjb3VudGluZyIpIHRvIG1ha2Ug c3VyZSB0aGUKPiA+ID4gPiBkcml2ZXIgZG9lcyBub3QgZGlzYXBwZWFyIGZyb20gdW5kZXJuZWF0 aCB1cy4gRXZlbiB3aXRoCj4gPiA+ID4gdGhvc2UgaGFja3Mgd2Ugd2VyZSBzdGlsbCBsZWZ0IHdp dGggYSBwb3RlbnRpYWwgTlVsbCBwb2ludGVyCj4gPiA+ID4gZGVyZWZlcmVuY2Ugc2NlbmFyaW8s IHNvIGp1c3QgY3JlYXRpbmcgdGhlIGRldmljZSBlbnRyaWVzLAo+ID4gPiA+IGFuZCBsZXR0aW5n IHRoZSBjb3JlIHRha2UgY2FyZSBvZiB0aGUgZGVwZW5kZW5jaWVzLiBObyBtb3JlCj4gPiA+ID4g aGFja3MgbmVlZGVkLgo+ID4gPiA+IAo+ID4gPiA+IEZpeGVzOiAzZTNiODE5NjVjYmYgKCJ1c2I6 IHR5cGVjOiBtdXg6IFRha2UgY2FyZSBvZiBkcml2ZXIgbW9kdWxlIHJlZmVyZW5jZSBjb3VudGlu ZyIpCj4gPiA+ID4gQ2M6IHY0LjE5LnggPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjQuMTku eCsKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBIZWlra2kgS3JvZ2VydXMgPGhlaWtraS5rcm9nZXJ1 c0BsaW51eC5pbnRlbC5jb20+Cj4gPiA+IAo+ID4gPiBUaGlzIGxvb2tzIGdvb2QgdG8gbWUsIG5p Y2Ugd29yayEKPiA+ID4gCj4gPiA+IEJ1dCwgaXQgd291bGQgYmUgbmljZSBpZiBzb21lb25lIHdo byBoYXMgdGhpcyBoYXJkd2FyZSBjYW4gdGVzdCBpdCB0bwo+ID4gPiB2ZXJpZnkgaXQgZG9lcyBh Y3R1YWxseSB3b3JrIDopCj4gPiAKPiA+IFRoaXMgYWxvbmUgZG9lcyBub3Qgd29yayBvbiBJbnRl bCBDaGVycnl0cmFpbCBwbGF0Zm9ybXMuIEkgbmVlZCB0byBtYWtlCj4gPiB0aGUgSW50ZWwgQ2hl cnJ5dHJhaWwgTUZEIGRyaXZlciAoaW50ZWxfY2h0X2ludDMzZmUuYykgdG8gdXNlIHRoZSBuZXcK PiA+IGRldmljZSBuYW1lcyB0aGF0IHdlIG5vdyBoYXZlIGZvciB0aGUgbXV4ZXMuIFNvcnJ5IGZv ciB0aGUgbWlzdGFrZS4KPiA+IAo+ID4gSSdsbCByZXNlbmQgdGhpcyBhbmQgaW5jbHVkZSB0aGUg bmVlZGVkIG1vZGlmaWNhdGlvbnMgdG8KPiA+IGludGVsX2NodF9pbnQzM2ZlLmMuIEhhbnMgc2hv dWxkIGJlIGFibGUgdG8gdGVzdCB0aGlzIG9uY2UgSSBkbyB0aGF0LiBJCj4gPiBob3BlIGhlIGhh cyB0aW1lLgo+IAo+IFllcyBJIG5lZWQgdG8gZ2V0IGJhY2sgdG8gdGhlIENoZXJyeVRyYWlsIFR5 cGUtQyBzdHVmZiB3ZSBkaXNjdXNzZWQgYSB3aGlsZQo+IGJhY2sgYW55d2F5cy4gT24gd2hpY2gg dHJlZS9icmFuY2ggc2hvdWxkIEkgdGVzdCB2MiBvZiB0aGlzIHBhdGNoKHNlcmllcykgPwoKR3Jl ZydzIHVzYi1uZXh0LgoKdGhhbmtzLAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E6ADC4360F for ; Tue, 2 Apr 2019 12:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1734020883 for ; Tue, 2 Apr 2019 12:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730256AbfDBMrw (ORCPT ); Tue, 2 Apr 2019 08:47:52 -0400 Received: from mga09.intel.com ([134.134.136.24]:53659 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729060AbfDBMrv (ORCPT ); Tue, 2 Apr 2019 08:47:51 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 05:47:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,300,1549958400"; d="scan'208";a="160634732" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 02 Apr 2019 05:47:48 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 02 Apr 2019 15:47:47 +0300 Date: Tue, 2 Apr 2019 15:47:47 +0300 From: Heikki Krogerus To: Hans de Goede Cc: Greg KH , linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] usb: typec: Registering real device entries for the muxes Message-ID: <20190402124747.GH9993@kuha.fi.intel.com> References: <20190401101553.45680-1-heikki.krogerus@linux.intel.com> <20190401103429.GA12128@kroah.com> <20190401124022.GF9993@kuha.fi.intel.com> <7a741768-af29-da82-4539-f97e49a17a56@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a741768-af29-da82-4539-f97e49a17a56@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 01, 2019 at 02:45:11PM +0200, Hans de Goede wrote: > HI, > > On 01-04-19 14:40, Heikki Krogerus wrote: > > On Mon, Apr 01, 2019 at 12:34:29PM +0200, Greg KH wrote: > > > On Mon, Apr 01, 2019 at 01:15:53PM +0300, Heikki Krogerus wrote: > > > > Registering real device entries (struct device) for the mode > > > > muxes as well as for the orientation switches. > > > > > > > > The Type-C mux code was deliberately attempting to avoid > > > > creation of separate device entries for the orientation > > > > switch and the mode switch (alternate modes) because they > > > > are not physical devices. They are functions of a single > > > > physical multiplexer/demultiplexer switch device. > > > > > > > > Unfortunately because of the dependency we still have on the > > > > underlying mux device driver, we had to put in hacks like > > > > the one in the commit 3e3b81965cbf ("usb: typec: mux: Take > > > > care of driver module reference counting") to make sure the > > > > driver does not disappear from underneath us. Even with > > > > those hacks we were still left with a potential NUll pointer > > > > dereference scenario, so just creating the device entries, > > > > and letting the core take care of the dependencies. No more > > > > hacks needed. > > > > > > > > Fixes: 3e3b81965cbf ("usb: typec: mux: Take care of driver module reference counting") > > > > Cc: v4.19.x # v4.19.x+ > > > > Signed-off-by: Heikki Krogerus > > > > > > This looks good to me, nice work! > > > > > > But, it would be nice if someone who has this hardware can test it to > > > verify it does actually work :) > > > > This alone does not work on Intel Cherrytrail platforms. I need to make > > the Intel Cherrytrail MFD driver (intel_cht_int33fe.c) to use the new > > device names that we now have for the muxes. Sorry for the mistake. > > > > I'll resend this and include the needed modifications to > > intel_cht_int33fe.c. Hans should be able to test this once I do that. I > > hope he has time. > > Yes I need to get back to the CherryTrail Type-C stuff we discussed a while > back anyways. On which tree/branch should I test v2 of this patch(series) ? Greg's usb-next. thanks, -- heikki