From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mark Brown <broonie@kernel.org>,
Simon Horman <horms+renesas@verge.net.au>,
linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
Subject: Re: [PATCH v2 3/3] spi: sh-msiof: Add reset of registers before starting transfer
Date: Tue, 2 Apr 2019 16:57:29 +0200 [thread overview]
Message-ID: <20190402145729.GF5389@kunai> (raw)
In-Reply-To: <20190402144023.27422-4-geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Tue, Apr 02, 2019 at 04:40:23PM +0200, Geert Uytterhoeven wrote:
> In accordance with hardware specification Ver 1.0, reset register
> transmission / reception setting before transfer.
>
> Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
> [geert: Use readl_poll_timeout_atomic()]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Minor nit:
> + /* reset registers */
> + sh_msiof_spi_reset_regs(p);
I don't think this comment adds value.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-04-02 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 14:40 [PATCH v2 0/3] spi: sh-msiof: Add reset of registers before starting transfer Geert Uytterhoeven
2019-04-02 14:40 ` [PATCH v2 1/3] spi: sh-msiof: Use BIT() and GENMASK() Geert Uytterhoeven
2019-04-02 14:48 ` Wolfram Sang
2019-04-03 4:43 ` Applied "spi: sh-msiof: Use BIT() and GENMASK()" to the spi tree Mark Brown
2019-04-02 14:40 ` [PATCH v2 2/3] spi: sh-msiof: Use readl_poll_timeout_atomic() instead of open-coding Geert Uytterhoeven
2019-04-02 14:51 ` Wolfram Sang
2019-04-03 4:42 ` Applied "spi: sh-msiof: Use readl_poll_timeout_atomic() instead of open-coding" to the spi tree Mark Brown
2019-04-03 6:54 ` Wolfram Sang
2019-04-03 8:06 ` Mark Brown
2019-04-02 14:40 ` [PATCH v2 3/3] spi: sh-msiof: Add reset of registers before starting transfer Geert Uytterhoeven
2019-04-02 14:57 ` Wolfram Sang [this message]
2019-04-03 4:42 ` Applied "spi: sh-msiof: Add reset of registers before starting transfer" to the spi tree Mark Brown
2019-04-02 14:47 ` [PATCH v2 0/3] spi: sh-msiof: Add reset of registers before starting transfer Wolfram Sang
2019-04-02 14:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402145729.GF5389@kunai \
--to=wsa@the-dreams.de \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=hiromitsu.yamasaki.ym@renesas.com \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.