From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 4/5] soc: ti: pm33xx: Push the am33xx_push_sram_idle to the top Date: Tue, 2 Apr 2019 10:34:03 -0700 Message-ID: <20190402173403.GQ49658@atomide.com> References: <20190402034253.4928-1-j-keerthy@ti.com> <20190402034253.4928-5-j-keerthy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190402034253.4928-5-j-keerthy@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Keerthy Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@bootlin.com, d-gerlach@ti.com, t-kristo@ti.com, ssantosh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org * Keerthy [190402 03:43]: > Push the am33xx_push_sram_idle function to the top as a preparation > for rtc+ddr mode as the function will be called by multiple functions > currently present before it. How about say "Move the am33xx_push_sram_idle function to the top..." instead? And mention no functional changes assuming there aren't any. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A88EFC4360F for ; Tue, 2 Apr 2019 17:34:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84D4120663 for ; Tue, 2 Apr 2019 17:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730802AbfDBReH (ORCPT ); Tue, 2 Apr 2019 13:34:07 -0400 Received: from muru.com ([72.249.23.125]:44070 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbfDBReH (ORCPT ); Tue, 2 Apr 2019 13:34:07 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 36402805F; Tue, 2 Apr 2019 17:34:21 +0000 (UTC) Date: Tue, 2 Apr 2019 10:34:03 -0700 From: Tony Lindgren To: Keerthy Cc: alexandre.belloni@bootlin.com, a.zummo@towertech.it, t-kristo@ti.com, ssantosh@kernel.org, d-gerlach@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 4/5] soc: ti: pm33xx: Push the am33xx_push_sram_idle to the top Message-ID: <20190402173403.GQ49658@atomide.com> References: <20190402034253.4928-1-j-keerthy@ti.com> <20190402034253.4928-5-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190402034253.4928-5-j-keerthy@ti.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org * Keerthy [190402 03:43]: > Push the am33xx_push_sram_idle function to the top as a preparation > for rtc+ddr mode as the function will be called by multiple functions > currently present before it. How about say "Move the am33xx_push_sram_idle function to the top..." instead? And mention no functional changes assuming there aren't any. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E8BBC4360F for ; Tue, 2 Apr 2019 17:34:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E1C220663 for ; Tue, 2 Apr 2019 17:34:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MRNBsncZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E1C220663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g+REzmjwnkzdJalXkS+eUQr8fE2mPDqMY57D7sv42Ik=; b=MRNBsncZU6s0eK +hbisKWzC+SMME0j5FmL/M38mMt3fnO6q8bilsDp1ysHXlS79QnDXMKmZy+riTpe0wkukgVZ4vObe j2Xvfknl0lkrsYwW069lYAUsTHxGHdIlD5y9OHm8+LBRT/hNyYV9MX6Id9xt25dtiiYiRxEHZBDuS a0M4yOeZ6M6xLszpHCHLakVftcKbC2o23cToRaufWhjWffxFsyZ/dAfbtZu4vp8Pili7CJnXYbqKp m69PjMQktpopE3SD8TH7JzYHMjAtpKEDExpKwJScV99CuE+94gDRa1Rz8HkoZQhif7wZXwIvn3NkZ ClThSajgj1r5GMCSO6dw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBNIY-0006qr-Uy; Tue, 02 Apr 2019 17:34:10 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBNIV-0006qY-7m for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 17:34:08 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 36402805F; Tue, 2 Apr 2019 17:34:21 +0000 (UTC) Date: Tue, 2 Apr 2019 10:34:03 -0700 From: Tony Lindgren To: Keerthy Subject: Re: [PATCH v2 4/5] soc: ti: pm33xx: Push the am33xx_push_sram_idle to the top Message-ID: <20190402173403.GQ49658@atomide.com> References: <20190402034253.4928-1-j-keerthy@ti.com> <20190402034253.4928-5-j-keerthy@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190402034253.4928-5-j-keerthy@ti.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_103407_318006_4D185186 X-CRM114-Status: UNSURE ( 5.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@bootlin.com, d-gerlach@ti.com, t-kristo@ti.com, ssantosh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Keerthy [190402 03:43]: > Push the am33xx_push_sram_idle function to the top as a preparation > for rtc+ddr mode as the function will be called by multiple functions > currently present before it. How about say "Move the am33xx_push_sram_idle function to the top..." instead? And mention no functional changes assuming there aren't any. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel