From: Greg KH <gregkh@linuxfoundation.org>
To: Andre Dainez <andredainez@gmail.com>
Cc: lkcamp@lists.libreplanetbr.org, realwakka@gmail.com,
straube.linux@gmail.com, hle@owl.eu.com, rico.schrage@gmail.com,
sophie.matter@web.de, Valentin.Vidic@carnet.hr, simon@nikanor.nu,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gdm724x: Add parenthesis to Macro arguments
Date: Wed, 3 Apr 2019 06:26:32 +0200 [thread overview]
Message-ID: <20190403042632.GA31130@kroah.com> (raw)
In-Reply-To: <1554253445-28635-1-git-send-email-andredainez@gmail.com>
On Tue, Apr 02, 2019 at 10:04:05PM -0300, Andre Dainez wrote:
> Fix checkpatch errors:
>
> CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence issues
> CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence issues
>
> Signed-off-by: Andre Dainez <andredainez@gmail.com>
> ---
> drivers/staging/gdm724x/netlink_k.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/netlink_k.c b/drivers/staging/gdm724x/netlink_k.c
> index 92440c3..36d88f4 100644
> --- a/drivers/staging/gdm724x/netlink_k.c
> +++ b/drivers/staging/gdm724x/netlink_k.c
> @@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
> #define ND_NLMSG_SPACE(len) (NLMSG_SPACE(len) + ND_IFINDEX_LEN)
> #define ND_NLMSG_DATA(nlh) ((void *)((char *)NLMSG_DATA(nlh) + \
> ND_IFINDEX_LEN))
> -#define ND_NLMSG_S_LEN(len) (len + ND_IFINDEX_LEN)
> -#define ND_NLMSG_R_LEN(nlh) (nlh->nlmsg_len - ND_IFINDEX_LEN)
> +#define ND_NLMSG_S_LEN(len) ((len) + ND_IFINDEX_LEN)
This makes sense, but:
> +#define ND_NLMSG_R_LEN(nlh) ((nlh)->nlmsg_len - ND_IFINDEX_LEN)
That does not, correct?
next prev parent reply other threads:[~2019-04-03 4:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 1:04 [PATCH] staging: gdm724x: Add parenthesis to Macro arguments Andre Dainez
2019-04-03 4:26 ` Greg KH [this message]
2019-04-08 17:37 ` Andre
2019-04-16 11:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403042632.GA31130@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Valentin.Vidic@carnet.hr \
--cc=andredainez@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=hle@owl.eu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=realwakka@gmail.com \
--cc=rico.schrage@gmail.com \
--cc=simon@nikanor.nu \
--cc=sophie.matter@web.de \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.