From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Wed, 03 Apr 2019 16:46:52 +0000 Subject: Re: [PATCH] aio: Fix an error code in __io_submit_one() Message-Id: <20190403164652.GP2217@ZenIV.linux.org.uk> List-Id: References: <20190403062235.GA1343@kadam> In-Reply-To: <20190403062235.GA1343@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, Apr 03, 2019 at 09:22:35AM +0300, Dan Carpenter wrote: > This accidentally returns the wrong variable. The "req->ki_eventfd" > pointer is NULL so this return success. Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E827DC4360F for ; Wed, 3 Apr 2019 16:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF7D12082C for ; Wed, 3 Apr 2019 16:46:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbfDCQq4 (ORCPT ); Wed, 3 Apr 2019 12:46:56 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:33370 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbfDCQqz (ORCPT ); Wed, 3 Apr 2019 12:46:55 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hBj2K-0003Rz-P1; Wed, 03 Apr 2019 16:46:52 +0000 Date: Wed, 3 Apr 2019 17:46:52 +0100 From: Al Viro To: Dan Carpenter Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] aio: Fix an error code in __io_submit_one() Message-ID: <20190403164652.GP2217@ZenIV.linux.org.uk> References: <20190403062235.GA1343@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190403062235.GA1343@kadam> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Apr 03, 2019 at 09:22:35AM +0300, Dan Carpenter wrote: > This accidentally returns the wrong variable. The "req->ki_eventfd" > pointer is NULL so this return success. Applied.