From: Matthias Kaehlcke <mka@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Alexandru M Stan <amstan@chromium.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Simon Glass <sjg@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Mark Brown <broonie@kernel.org>,
Ryan Case <ryandcase@chromium.org>,
Randall Spangler <rspangler@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] platform/chrome: cros_ec_spi: Transfer messages at high priority
Date: Wed, 3 Apr 2019 11:30:10 -0700 [thread overview]
Message-ID: <20190403183010.GR112750@google.com> (raw)
In-Reply-To: <CAD=FV=UC6MpTgmir+nwUy4hWk8Vvz97M5G45=-r5JAg_=z6vQQ@mail.gmail.com>
On Wed, Apr 03, 2019 at 11:17:27AM -0700, Doug Anderson wrote:
> Hi,
>
> On Wed, Apr 3, 2019 at 11:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> > Each transfer has it's own work struct (allocated on the stack), hence
> > a) does not occur. b) is still true, but shouldn't be a problem on
> > its own.
>
> Actually, it could be much worse _because_ it's on the stack. The
> worker could write something back to the work after the work has been
> de-allocated. That's bad.
Sure, I said "not a problem on its own."
~~~~~~~~~~
The worker is owned by this driver and supposedly we know what we are
doing. Changing a member in the struct after calling complete() would
likely be a bug anyway (though not necessarily a fatal one).
next prev parent reply other threads:[~2019-04-03 18:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 16:05 [PATCH v2] platform/chrome: cros_ec_spi: Transfer messages at high priority Douglas Anderson
2019-04-03 17:04 ` Brian Norris
2019-04-03 17:49 ` Doug Anderson
[not found] ` <CAD=FV=UZCUp=Tq4DhKGJQm7bPvvM1Q=EUovWeBdoHVvQeu4eUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-04-03 17:55 ` Brian Norris
2019-04-03 17:55 ` Brian Norris
2019-04-03 18:14 ` Matthias Kaehlcke
2019-04-03 18:17 ` Doug Anderson
2019-04-03 18:30 ` Matthias Kaehlcke [this message]
2019-04-03 18:39 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403183010.GR112750@google.com \
--to=mka@chromium.org \
--cc=amstan@chromium.org \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rspangler@chromium.org \
--cc=ryandcase@chromium.org \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.