From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority Date: Wed, 3 Apr 2019 14:19:43 -0700 Message-ID: <20190403211943.GT112750@google.com> References: <20190403203137.203582-1-dianders@chromium.org> <20190403210436.GS112750@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: Benson Leung , Enric Balletbo i Serra , Alexandru M Stan , "open list:ARM/Rockchip SoC..." , Simon Glass , Brian Norris , Guenter Roeck , Mark Brown , Ryan Case , Randall Spangler , Heiko =?utf-8?Q?St=C3=BCbner?= , LKML List-Id: linux-rockchip.vger.kernel.org On Wed, Apr 03, 2019 at 02:08:40PM -0700, Doug Anderson wrote: > Hi, > > On Wed, Apr 3, 2019 at 2:04 PM Matthias Kaehlcke wrote: > > > +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev, > > > > nit: the fact that a high priority workqueue is used is an > > implementation detail, since the driver has no function to perform a > > transfer with 'normal'/low priority there is no need to distinguish > > between the two cases. In this sense I'd be inclined to remove the > > 'high_pri' from the function names. > > > > Sorry for not mentioning this earlier, I focussed on other > > details, anyway it's just a nit. > > I still kinda like having the "high_pri" in there since the point of > this function is to transfer the work onto the high priority > workqueue. It's not an exported function so having the implementation > detail leak into the name isn't a bad thing, is it? IMO the long name with details mostly irrelevant to the caller (they want to do a 'normal' transfer, the function should do the right thing to get that done) is more distracting than helpful. But yeah, this is definitely 'nit/bikeshed' territory ;-) > ...so unless someone else thinks the name should change or you feel > strongly about it I won't plan to change the name. no strong feelings on my side, just wanted to mention it.