From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Date: Wed, 03 Apr 2019 22:02:00 +0000 Subject: Re: [PATCH] platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer Message-Id: <20190403220200.GC39081@wrath> List-Id: References: <20190330001712.8923-1-colin.king@canonical.com> In-Reply-To: <20190330001712.8923-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Andy Shevchenko , platform-driver-x86@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Sat, Mar 30, 2019 at 12:17:12AM +0000, Colin King wrote: > From: Colin Ian King > > Currently the kfree of output.pointer can be potentially freeing > an uninitalized pointer in the case where out_data is NULL. Fix this > by reworking the case where out_data is not-null to perform the > ACPI status check and also the kfree of outpoint.pointer in one block > and hence ensuring the pointer is only freed when it has been used. > > Also replace the if (ptr != NULL) idiom with just if (ptr). > > Fixes: ff0e9f26288d ("platform/x86: alienware-wmi: Correct a memory leak") > Signed-off-by: Colin Ian King Thanks for the catch Colin, queued for testing. Did you trigger this error or detect it via review or static analysis? -- Darren Hart VMware Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH] platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer Date: Wed, 3 Apr 2019 15:02:00 -0700 Message-ID: <20190403220200.GC39081@wrath> References: <20190330001712.8923-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190330001712.8923-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: Andy Shevchenko , platform-driver-x86@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Sat, Mar 30, 2019 at 12:17:12AM +0000, Colin King wrote: > From: Colin Ian King > > Currently the kfree of output.pointer can be potentially freeing > an uninitalized pointer in the case where out_data is NULL. Fix this > by reworking the case where out_data is not-null to perform the > ACPI status check and also the kfree of outpoint.pointer in one block > and hence ensuring the pointer is only freed when it has been used. > > Also replace the if (ptr != NULL) idiom with just if (ptr). > > Fixes: ff0e9f26288d ("platform/x86: alienware-wmi: Correct a memory leak") > Signed-off-by: Colin Ian King Thanks for the catch Colin, queued for testing. Did you trigger this error or detect it via review or static analysis? -- Darren Hart VMware Open Source Technology Center