From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] package/libcamera: Add libcamera package
Date: Wed, 3 Apr 2019 22:55:28 +0200 [thread overview]
Message-ID: <20190403225528.4d00a4c8@windsurf> (raw)
In-Reply-To: <20190403112902.29930-1-kieran.bingham@ideasonboard.com>
Hello Kieran,
On Wed, 3 Apr 2019 18:29:02 +0700
Kieran Bingham <kieran.bingham@ideasonboard.com> wrote:
> http://libcamera.org/
I've applied to master, with a few minor changes.
First, our canonical commit title for new packages is:
package/foo: new package
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> new file mode 100644
> index 000000000000..cc5e84424c38
> --- /dev/null
> +++ b/package/libcamera/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LIBCAMERA
> + bool "libcamera"
> + depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + # C++11 + https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54316
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5
> + depends on BR2_PACKAGE_HAS_UDEV
> + help
> + libcamera provides a software stack to support
> + complex devices that need heavy hardware image
> + processing operations.
> +
> + http://www.libcamera.org/
The indentation of the URL should have been one tab + two spaces.
More importantly (and that was the only thing really missing): the
Config.in comment that describes the dependencies was missing.
> diff --git a/package/libcamera/libcamera.hash b/package/libcamera/libcamera.hash
> new file mode 100644
> index 000000000000..7d5392dde2bb
> --- /dev/null
> +++ b/package/libcamera/libcamera.hash
> @@ -0,0 +1,4 @@
> +sha256 2c01dc76d98ef257660f8ef3f4f17f042e112b5eca6b364ad615220c96fbd066 libcamera-d5ca33f6c7b0cd1ca20ec5dc7131aeedf1503080.tar.gz
> +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 licenses/gnu-gpl-2.0.txt
> +sha256 592987e8510228d546540b84a22444bde98e48d03078d3b2eefcd889bec5ce8c licenses/gnu-lgpl-2.1.txt
> +
Unneeded empty new line that was causing a check-package warning.
Thanks for this contribution! Great to see libcamera moving forward!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-04-03 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 11:29 [Buildroot] [PATCH v3] package/libcamera: Add libcamera package Kieran Bingham
2019-04-03 11:32 ` Arnout Vandecappelle
2019-04-03 18:23 ` Kieran Bingham
2019-04-03 20:38 ` Yann E. MORIN
2019-04-03 20:55 ` Thomas Petazzoni [this message]
2019-04-04 3:53 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403225528.4d00a4c8@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.