All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 1/1] package/libwebsockets: bump version to 3.1.0
Date: Wed, 3 Apr 2019 23:18:30 +0200	[thread overview]
Message-ID: <20190403231830.2cc94b07@windsurf> (raw)
In-Reply-To: <CAFSsvmo4vvANQse18AxJ8RyK4KZfLWBBZVAafeNUAM_G5EKc=g@mail.gmail.com>

Hello Adam,

On Wed, 27 Feb 2019 12:19:17 -0500
Adam Duskett <aduskett@gmail.com> wrote:

> We are removing the check for three reasons that I can see:
> 1) Libwebsockets works just fine with both libev and libevent with
> this check removed.
> 2) Some people may be using libwebsockets with libev and libevent
> installed, and this is the least disruptive patch.
> 3) If I had set a check in the make file that favored either libev or
> libevent over the other, who is to say that one should take
>     precedence over the other?

Where do we stand with this? I remember we discussed it on IRC.

If libwebsockets is only using libev *or* libevent, this should be
reflected in the .mk file, and the libwebsockets should not be patched.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-04-03 21:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23 20:17 [Buildroot] [PATCH next 1/1] package/libwebsockets: bump version to 3.1.0 aduskett at gmail.com
2019-02-25 21:20 ` Thomas Petazzoni
2019-02-27 17:19   ` Adam Duskett
2019-04-03 21:18     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403231830.2cc94b07@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.