From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FDE2C4360F for ; Thu, 4 Apr 2019 09:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 485D5205F4 for ; Thu, 4 Apr 2019 09:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554370637; bh=fperMca8X9y+RuhVlWfPNVHQgXhrUvnYR+6dxBKry8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=D4h+LPGFflFdKLlXhECCdG024qfvTV9k845Bn9GdZnrBJlEbn4Pmt+0uM32efk4YQ BcG9yGUsGIMwZMAVxY0FNUYKiTHHTeInzlxL+LqFyZ+NQsPhK3l8Bg5K9rauTqXjKR LqpaLfphFhYF3hRiMH4a4f3w5yMD1rzaCo8IC1mk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732086AbfDDJFH (ORCPT ); Thu, 4 Apr 2019 05:05:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:43072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727525AbfDDJFE (ORCPT ); Thu, 4 Apr 2019 05:05:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D8D32177E; Thu, 4 Apr 2019 09:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554368703; bh=fperMca8X9y+RuhVlWfPNVHQgXhrUvnYR+6dxBKry8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y21JHzCvX+UmvT1vQprRbYXrx7ulj6l+YFa2s3hPNB/Sxp/iNs7kWZ6v3AQK2/w0w aPfyJiZ9vUEHMw+A4G2aUmYhod0tHGVMylAEjTSS2Y70lLenqwGRY/XQt4MdiEPUXz zvbTVBvj+KiE418pk1/rLiP7bysAzbNRhQs+5yrQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexey Khoroshilov , Bjorn Andersson , Andy Gross , Sasha Levin Subject: [PATCH 4.19 138/187] soc: qcom: gsbi: Fix error handling in gsbi_probe() Date: Thu, 4 Apr 2019 10:47:55 +0200 Message-Id: <20190404084609.695941782@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190404084603.119654039@linuxfoundation.org> References: <20190404084603.119654039@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 8cd09a3dd3e176c62da67efcd477a44a8d87185e ] If of_platform_populate() fails in gsbi_probe(), gsbi->hclk is left undisabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Signed-off-by: Bjorn Andersson Signed-off-by: Andy Gross Signed-off-by: Sasha Levin --- drivers/soc/qcom/qcom_gsbi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c index 09c669e70d63..038abc377fdb 100644 --- a/drivers/soc/qcom/qcom_gsbi.c +++ b/drivers/soc/qcom/qcom_gsbi.c @@ -138,7 +138,7 @@ static int gsbi_probe(struct platform_device *pdev) struct resource *res; void __iomem *base; struct gsbi_info *gsbi; - int i; + int i, ret; u32 mask, gsbi_num; const struct crci_config *config = NULL; @@ -221,7 +221,10 @@ static int gsbi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, gsbi); - return of_platform_populate(node, NULL, NULL, &pdev->dev); + ret = of_platform_populate(node, NULL, NULL, &pdev->dev); + if (ret) + clk_disable_unprepare(gsbi->hclk); + return ret; } static int gsbi_remove(struct platform_device *pdev) -- 2.19.1