From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lucas Oshiro <lucasseikioshiro@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
stefan.popa@analog.com, jic23@kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com
Subject: Re: [PATCH] staging: iio: cdc: ad7746: Replace bitshift by BIT
Date: Thu, 4 Apr 2019 12:12:06 +0300 [thread overview]
Message-ID: <20190404091206.GI32590@kadam> (raw)
In-Reply-To: <20190403204502.28917-1-lucasseikioshiro@gmail.com>
On Wed, Apr 03, 2019 at 05:45:02PM -0300, Lucas Oshiro wrote:
> #define AD7746_VTSETUP_VTMD_INT_TEMP (0 << 5)
> -#define AD7746_VTSETUP_VTMD_EXT_TEMP (1 << 5)
> +#define AD7746_VTSETUP_VTMD_EXT_TEMP BIT(5)
No, the original is more readable. Otherwise you can't see that it's
part of a set.
Just ignore checkpatch when it gives nonsense advice.
regards,
dan carpenter
next prev parent reply other threads:[~2019-04-04 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 20:45 [PATCH] staging: iio: cdc: ad7746: Replace bitshift by BIT Lucas Oshiro
2019-04-04 6:41 ` Alexandru Ardelean
2019-04-04 9:12 ` Dan Carpenter [this message]
2019-04-08 12:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404091206.GI32590@kadam \
--to=dan.carpenter@oracle.com \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucasseikioshiro@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.