From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D536EC4360F for ; Thu, 4 Apr 2019 10:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3C6720882 for ; Thu, 4 Apr 2019 10:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729159AbfDDKWA (ORCPT ); Thu, 4 Apr 2019 06:22:00 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:48026 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728733AbfDDKWA (ORCPT ); Thu, 4 Apr 2019 06:22:00 -0400 Received: from localhost.localdomain ([127.0.0.1]:45482 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S23991965AbfDDKVzSWnrV (ORCPT ); Thu, 4 Apr 2019 12:21:55 +0200 Received: from h7.dl5rb.org.uk (localhost [127.0.0.1]) by h7.dl5rb.org.uk (8.15.2/8.15.2) with ESMTP id x34ALs7D013229 for ; Thu, 4 Apr 2019 12:21:54 +0200 Received: (from ralf@localhost) by h7.dl5rb.org.uk (8.15.2/8.15.2/Submit) id x34ALsOM013228 for netdev@vger.kernel.org; Thu, 4 Apr 2019 12:21:54 +0200 Date: Thu, 4 Apr 2019 12:21:54 +0200 From: Ralf Baechle To: netdev@vger.kernel.org Subject: iproute2: Issue with link type link/generic for NETROM links Message-ID: <20190404102154.GA427@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org For a NETROM "ip link show dev nr0" will show 4: nr0: mtu 236 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000 link/generic 88:98:6a:a4:84:40:0a brd 00:00:00:00:00:00:00 But rather link/netrom is expected to be displayed. I have below patch to change ip such that link/netrom will be displayed but I'm wondering if it's going to cause non-obvious breakage or would be acceptable? Thanks, Ralf Signed-off-by: Ralf Baechle lib/ll_types.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ll_types.c b/lib/ll_types.c index bd8893ed..32d04b5a 100644 --- a/lib/ll_types.c +++ b/lib/ll_types.c @@ -32,7 +32,7 @@ static const struct { int type; const char *name; } arphrd_names[] = { -{ 0, "generic" }, +__PF(NETROM,netrom) __PF(ETHER,ether) __PF(EETHER,eether) __PF(AX25,ax25)