Re: [igt-dev] [PATCH i-g-t] lib/rendercopy: Assert that buffer dimensions/stride are acceptable

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/rendercopy: Assert that buffer dimensions/stride are acceptable
Date: Thu, 4 Apr 2019 13:50:55 +0300	[thread overview]
Message-ID: <20190404105055.GC3888@intel.com> (raw)
In-Reply-To: <155436381344.7532.1708058939274624952@skylake-alporthouse-com>

On Thu, Apr 04, 2019 at 08:43:38AM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2019-04-03 16:41:04)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Sprinkle some asserts into rendercopy to make sure we don't try
> > to exceed the render engine surface size/stride limitations.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > diff --git a/lib/rendercopy_gen6.c b/lib/rendercopy_gen6.c
> > index f4c0105a80db..a6157cfc70f6 100644
> > --- a/lib/rendercopy_gen6.c
> > +++ b/lib/rendercopy_gen6.c
> > @@ -79,6 +79,10 @@ gen6_bind_buf(struct intel_batchbuffer *batch, const struct igt_buf *buf,
> >         uint32_t write_domain, read_domain;
> >         int ret;
> >  
> > +       igt_assert_lte(buf->stride, 128*1024);
> > +       igt_assert_lte(igt_buf_width(buf), 8192);
> > +       igt_assert_lte(igt_buf_height(buf), 8192);
> 
> Indeed. I had it down as 256k, but the field seems to be only 17b and
> not 18b as ivb+.

Yeah, I had the same misconception when working on the gtt remapping
stuff. Also some version of the spec even mistakenly documented it
as 512k IIRC

> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Ta. Pushed.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev