From: Bill O'Donnell <billodo@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] scrub: fix typo in unicrash header file
Date: Thu, 4 Apr 2019 13:06:21 -0500 [thread overview]
Message-ID: <20190404180621.GA7627@redhat.com> (raw)
In-Reply-To: <9e34ab3e-b9ed-6c4c-ce69-97f0f78b9503@redhat.com>
On Thu, Apr 04, 2019 at 12:24:40PM -0500, Eric Sandeen wrote:
> The no-op #definintion was missing 'fs_' so remained undefined
> in the #else case.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Looks good.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
>
> diff --git a/scrub/unicrash.h b/scrub/unicrash.h
> index 85fcabc..fb8f5f7 100644
> --- a/scrub/unicrash.h
> +++ b/scrub/unicrash.h
> @@ -28,7 +28,7 @@ bool unicrash_check_fs_label(struct unicrash *uc, const char *descr,
> #else
> # define unicrash_dir_init(u, c, b) (true)
> # define unicrash_xattr_init(u, c, b) (true)
> -# define unicrash_label_init(u, c) (true)
> +# define unicrash_fs_label_init(u, c) (true)
> # define unicrash_free(u) do {(u) = (u);} while (0)
> # define unicrash_check_dir_name(u, d, n) (true)
> # define unicrash_check_xattr_name(u, d, n) (true)
>
prev parent reply other threads:[~2019-04-04 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 17:24 [PATCH] scrub: fix typo in unicrash header file Eric Sandeen
2019-04-04 18:01 ` Darrick J. Wong
2019-04-04 18:06 ` Bill O'Donnell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404180621.GA7627@redhat.com \
--to=billodo@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.