All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the hwmon-staging tree
Date: Thu, 4 Apr 2019 14:26:18 -0700	[thread overview]
Message-ID: <20190404212618.GA20949@roeck-us.net> (raw)
In-Reply-To: <20190405075438.12f98275@canb.auug.org.au>

On Fri, Apr 05, 2019 at 07:54:38AM +1100, Stephen Rothwell wrote:
> Hi Guenter,
> 
> In commit
> 
>   742ad88f0440 ("hwmon: (smsc47b397) Use request_muxed_region for Super-IO accesses")
> 
> Fixes tag
> 
>   Fixes: 8d5d45fb1468 ("I2C: Move hwmon drivers (2/3)")
> 
The original subject is "[PATCH] I2C: Move hwmon drivers (2/3)", and
I consider it quite pointless to include the "[PATCH] " prefix.
Same for the other tag.

Guenter

> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h (%s)'
> 
> In commit
> 
>   4d730440042d ("hwmon: (smsc47b397) Use request_muxed_region for Super-IO accesses")
> 
> Fixes tag
> 
>   Fixes: 8d5d45fb1468 ("I2C: Move hwmon drivers (2/3)")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h (%s)'
> 
> In commit
> 
>   2f38d5d31508 ("hwmon: (f71805f) Use request_muxed_region for Super-IO accesses")
> 
> Fixes tag
> 
>   Fixes: e53004e20a58e ("hwmon: New f71805f driver")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h (%s)'
> 
> -- 
> Cheers,
> Stephen Rothwell

  reply	other threads:[~2019-04-04 21:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 20:54 linux-next: Fixes tag needs some work in the hwmon-staging tree Stephen Rothwell
2019-04-04 21:26 ` Guenter Roeck [this message]
2019-04-04 23:04   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2022-04-25 22:28 Stephen Rothwell
2022-04-26  7:12 ` Camel Guo
2022-09-22 10:20 Stephen Rothwell
2022-09-22 13:05 ` Farber, Eliav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190404212618.GA20949@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.