From: Al Viro <viro@zeniv.linux.org.uk>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>,
Alexander Viro <viro@ftp.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Christopher Lameter <cl@linux.com>,
Matthew Wilcox <willy@infradead.org>,
Miklos Szeredi <mszeredi@redhat.com>,
Andreas Dilger <adilger@dilger.ca>,
Waiman Long <longman@redhat.com>, Tycho Andersen <tycho@tycho.ws>,
Theodore Ts'o <tytso@mit.edu>, Andi Kleen <ak@linux.intel.com>,
David Chinner <david@fromorbit.com>,
Nick Piggin <npiggin@gmail.com>, Rik van Riel <riel@redhat.com>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC PATCH v2 14/14] dcache: Implement object migration
Date: Thu, 4 Apr 2019 22:58:10 +0100 [thread overview]
Message-ID: <20190404215810.GG2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190404202914.GA16709@eros.localdomain>
On Fri, Apr 05, 2019 at 07:29:14AM +1100, Tobin C. Harding wrote:
> > __d_alloc() is not holding ->d_lock, since the object is not visible to
> > anybody else yet; with your changes it *is* visible.
>
> I don't quite understand this comment. How is the object visible? The
> constructor is only called when allocating a new page to the slab and
> this is done with interrupts disabled.
Not to constructor, to your try-to-evict code...
next prev parent reply other threads:[~2019-04-04 21:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 4:21 [RFC PATCH v2 00/14] Slab Movable Objects (SMO) Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 01/14] slub: Add isolate() and migrate() methods Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 02/14] tools/vm/slabinfo: Add support for -C and -M options Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 03/14] slub: Sort slab cache list Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 04/14] slub: Slab defrag core Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 05/14] tools/vm/slabinfo: Add remote node defrag ratio output Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 06/14] tools/vm/slabinfo: Add defrag_used_ratio output Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 07/14] tools/testing/slab: Add object migration test module Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 08/14] tools/testing/slab: Add object migration test suite Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 09/14] xarray: Implement migration function for objects Tobin C. Harding
2019-04-03 17:23 ` Matthew Wilcox
2019-04-03 21:19 ` Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 10/14] tools/testing/slab: Add XArray movable objects tests Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 11/14] slub: Enable moving objects to/from specific nodes Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 12/14] slub: Enable balancing slabs across nodes Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 13/14] dcache: Provide a dentry constructor Tobin C. Harding
2019-04-03 4:21 ` [RFC PATCH v2 14/14] dcache: Implement object migration Tobin C. Harding
2019-04-03 17:08 ` Al Viro
2019-04-03 17:19 ` Al Viro
2019-04-03 17:48 ` Al Viro
2019-04-04 20:29 ` Tobin C. Harding
2019-04-04 21:58 ` Al Viro [this message]
2019-04-04 21:18 ` Tobin C. Harding
2019-04-03 17:56 ` Christopher Lameter
2019-04-03 18:24 ` Al Viro
2019-04-03 19:05 ` Al Viro
2019-04-04 8:01 ` Miklos Szeredi
2019-04-04 15:46 ` Christopher Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404215810.GG2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adilger@dilger.ca \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=david@fromorbit.com \
--cc=guro@fb.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=me@tobin.cc \
--cc=mszeredi@redhat.com \
--cc=npiggin@gmail.com \
--cc=penberg@cs.helsinki.fi \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=tobin@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@tycho.ws \
--cc=tytso@mit.edu \
--cc=viro@ftp.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.