From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/android-tools: fix static build failure due to missing -latomic
Date: Thu, 4 Apr 2019 22:45:39 +0200 [thread overview]
Message-ID: <20190404224539.2d79cf30@windsurf> (raw)
In-Reply-To: <20190404153904.69693-1-giulio.benetti@micronovasrl.com>
Hello Giulio,
On Thu, 4 Apr 2019 17:39:04 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> +# Uses __atomic_fetch_add_4. In adbd.mk Makefile there is no hunk to the end of
> +# linking command. So need to add -latomic to LIBS using sed to provide
> +# -latomic at the correct place in the linking command.
> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +define ANDROID_TOOLS_FIX_MAKEFILE
> + $(SED) 's/-lz -lcrypt/-lz -lcrypt -latomic/' $(@D)/debian/makefiles/adbd.mk
> +endef
> +ANDROID_TOOLS_POST_PATCH_HOOKS = ANDROID_TOOLS_FIX_MAKEFILE
> +endif
Instead of this, please do regular patch on adbd.mk that does this:
-LIBS+= -lc -lpthread -lz -lcrypto -lcrypt `pkg-config --libs glib-2.0 gio-2.0`
+LIBS+= -lc -lpthread -lz `pkg-config --libs libcrypto` -lcrypt `pkg-config --libs glib-2.0 gio-2.0`
and that's it.
Also, adding host-pkgconf to ANDROID_TOOLS_DEPENDENCIES when adbd is
selected would be necessary (but it should already be needed anyway, as
pkg-config is already used to detect glib).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-04-04 20:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 15:39 [Buildroot] [PATCH] package/android-tools: fix static build failure due to missing -latomic Giulio Benetti
2019-04-04 20:45 ` Thomas Petazzoni [this message]
[not found] ` <699842f1-d9e3-dd02-4770-e8a10499194b@micronovasrl.com>
2019-04-07 21:55 ` Giulio Benetti
2019-04-08 7:18 ` Thomas Petazzoni
2019-04-08 7:43 ` Giulio Benetti
2019-04-08 9:04 ` Thomas Petazzoni
2019-04-08 15:43 ` [Buildroot] [PATCH] package/android-tools: fix static linking failure due to lack of deps Giulio Benetti
2019-04-08 20:34 ` Thomas Petazzoni
2019-04-14 21:19 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404224539.2d79cf30@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.