From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62563C282DC for ; Fri, 5 Apr 2019 21:29:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DE87205F4 for ; Fri, 5 Apr 2019 21:29:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726419AbfDEV3B (ORCPT ); Fri, 5 Apr 2019 17:29:01 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:34532 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbfDEV3A (ORCPT ); Fri, 5 Apr 2019 17:29:00 -0400 Received: by mail-qt1-f195.google.com with SMTP id k2so9171366qtm.1 for ; Fri, 05 Apr 2019 14:29:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oYMolIwAx+J/BMA/57MBDIuPlirQIxRmyaFFYP2t9mI=; b=Ai7U+V18A8/wYDGu5FmjE9iLGgSm5ZZ+qwuXN4iSvWMEYQUShgVhZj+X2ecIYyQ1u2 YcbQjDY4o3JBZZizRSZxFO0FFv5ts2UIHz1TjIXbS8yNJqM1PzvXFJ8GGqXRU0KyLjon rXZLVMa39mMaFpNac3eB4kXz7gvUVPKqsU8vt4q3E4jGfSy/Bfcm4/mLiAcD7OYsfxa3 Liv/+76NM+5cLRhuhe2fDbOqdiRYi4FlqN1fEKggl3pJzYJSG1ul7Dyl2VLeJsAxieJX sMZAJQdPxha1oD6jgIBVFb+kBZRec973LYyWVUTih5JdMoGiR46rjPxNlhHcpMKV+gw6 mDhw== X-Gm-Message-State: APjAAAVKAOQDAJXfSZhq93CRykeEnxb5UMuGlTmLXg+17pqK7PTTYB9I Uw9csoC3Qznosp8gKxbW4jrnwA== X-Google-Smtp-Source: APXvYqzWiT7lMUKvvlNlaUVqXjncJbg3ltJmrWIGLkWyykgjRXp2ymAmUEXjuozEG7odjzJW3bxMCw== X-Received: by 2002:ac8:260f:: with SMTP id u15mr13088347qtu.109.1554499739536; Fri, 05 Apr 2019 14:28:59 -0700 (PDT) Received: from redhat.com (pool-173-76-246-42.bstnma.fios.verizon.net. [173.76.246.42]) by smtp.gmail.com with ESMTPSA id h2sm10533658qkl.3.2019.04.05.14.28.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Apr 2019 14:28:58 -0700 (PDT) Date: Fri, 5 Apr 2019 17:28:55 -0400 From: "Michael S. Tsirkin" To: Si-Wei Liu Cc: sridhar.samudrala@intel.com, stephen@networkplumber.org, davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com Subject: Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces Message-ID: <20190405172835-mutt-send-email-mst@kernel.org> References: <1554267167-17561-1-git-send-email-si-wei.liu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1554267167-17561-1-git-send-email-si-wei.liu@oracle.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 03, 2019 at 12:52:47AM -0400, Si-Wei Liu wrote: > When a netdev appears through hot plug then gets enslaved by a failover > master that is already up and running, the slave will be opened > right away after getting enslaved. Today there's a race that userspace > (udev) may fail to rename the slave if the kernel (net_failover) > opens the slave earlier than when the userspace rename happens. > Unlike bond or team, the primary slave of failover can't be renamed by > userspace ahead of time, since the kernel initiated auto-enslavement is > unable to, or rather, is never meant to be synchronized with the rename > request from userspace. > > As the failover slave interfaces are not designed to be operated > directly by userspace apps: IP configuration, filter rules with > regard to network traffic passing and etc., should all be done on master > interface. In general, userspace apps only care about the > name of master interface, while slave names are less important as long > as admin users can see reliable names that may carry > other information describing the netdev. For e.g., they can infer that > "ens3nsby" is a standby slave of "ens3", while for a > name like "eth0" they can't tell which master it belongs to. > > Historically the name of IFF_UP interface can't be changed because > there might be admin script or management software that is already > relying on such behavior and assumes that the slave name can't be > changed once UP. But failover is special: with the in-kernel > auto-enslavement mechanism, the userspace expectation for device > enumeration and bring-up order is already broken. Previously initramfs > and various userspace config tools were modified to bypass failover > slaves because of auto-enslavement and duplicate MAC address. Similarly, > in case that users care about seeing reliable slave name, the new type > of failover slaves needs to be taken care of specifically in userspace > anyway. > > It's less risky to lift up the rename restriction on failover slave > which is already UP. Although it's possible this change may potentially > break userspace component (most likely configuration scripts or > management software) that assumes slave name can't be changed while > UP, it's relatively a limited and controllable set among all userspace > components, which can be fixed specifically to listen for the rename > and/or link down/up events on failover slaves. Userspace component > interacting with slaves is expected to be changed to operate on failover > master interface instead, as the failover slave is dynamic in nature > which may come and go at any point. The goal is to make the role of > failover slaves less relevant, and userspace components should only > deal with failover master in the long run. > > Fixes: 30c8bd5aa8b2 ("net: Introduce generic failover module") > Signed-off-by: Si-Wei Liu > Reviewed-by: Liran Alon Acked-by: Michael S. Tsirkin Stephen are you happy with this approach? > -- > v1 -> v2: > - Drop configurable module parameter (Sridhar) > > v2 -> v3: > - Drop additional IFF_SLAVE_RENAME_OK flag (Sridhar) > - Send down and up events around rename (Michael S. Tsirkin) > > v3 -> v4: > - Simplify notification to be sent (Stephen Hemminger) > > v4 -> v5: > - Sync up code with latest net-next (Sridhar) > - Use proper structure initialization (Stephen, Jiri) > > v5 -> v6: > - Make the property of live name change a generic flag (Stephen) > --- > include/linux/netdevice.h | 3 +++ > net/core/dev.c | 25 ++++++++++++++++++++++++- > net/core/failover.c | 6 +++--- > 3 files changed, 30 insertions(+), 4 deletions(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 78f5ec4e..ea9a63f 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1498,6 +1498,7 @@ struct net_device_ops { > * @IFF_FAILOVER: device is a failover master device > * @IFF_FAILOVER_SLAVE: device is lower dev of a failover master device > * @IFF_L3MDEV_RX_HANDLER: only invoke the rx handler of L3 master device > + * @IFF_LIVE_NAME_CHANGE: rename is allowed while device is running > */ > enum netdev_priv_flags { > IFF_802_1Q_VLAN = 1<<0, > @@ -1530,6 +1531,7 @@ enum netdev_priv_flags { > IFF_FAILOVER = 1<<27, > IFF_FAILOVER_SLAVE = 1<<28, > IFF_L3MDEV_RX_HANDLER = 1<<29, > + IFF_LIVE_NAME_CHANGE = 1<<30, > }; > > #define IFF_802_1Q_VLAN IFF_802_1Q_VLAN > @@ -1561,6 +1563,7 @@ enum netdev_priv_flags { > #define IFF_FAILOVER IFF_FAILOVER > #define IFF_FAILOVER_SLAVE IFF_FAILOVER_SLAVE > #define IFF_L3MDEV_RX_HANDLER IFF_L3MDEV_RX_HANDLER > +#define IFF_LIVE_NAME_CHANGE IFF_LIVE_NAME_CHANGE > > /** > * struct net_device - The DEVICE structure. > diff --git a/net/core/dev.c b/net/core/dev.c > index 9823b77..48341d5 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -1185,7 +1185,21 @@ int dev_change_name(struct net_device *dev, const char *newname) > BUG_ON(!dev_net(dev)); > > net = dev_net(dev); > - if (dev->flags & IFF_UP) > + > + /* Some auto-enslaved devices e.g. failover slaves are > + * special, as userspace might rename the device after > + * the interface had been brought up and running since > + * the point kernel initiated auto-enslavement. Allow > + * live name change even when these slave devices are > + * up and running. > + * > + * Typically, users of these auto-enslaving devices > + * don't actually care about slave name change, as > + * they are supposed to operate on master interface > + * directly. > + */ > + if (dev->flags & IFF_UP && > + likely(!(dev->priv_flags & IFF_LIVE_NAME_CHANGE))) > return -EBUSY; > > write_seqcount_begin(&devnet_rename_seq); > @@ -1232,6 +1246,15 @@ int dev_change_name(struct net_device *dev, const char *newname) > hlist_add_head_rcu(&dev->name_hlist, dev_name_hash(net, dev->name)); > write_unlock_bh(&dev_base_lock); > > + if (unlikely(dev->flags & IFF_UP)) { > + struct netdev_notifier_change_info change_info = { > + .info.dev = dev, > + }; > + > + call_netdevice_notifiers_info(NETDEV_CHANGE, > + &change_info.info); > + } > + > ret = call_netdevice_notifiers(NETDEV_CHANGENAME, dev); > ret = notifier_to_errno(ret); > > diff --git a/net/core/failover.c b/net/core/failover.c > index 4a92a98..b5cd3c7 100644 > --- a/net/core/failover.c > +++ b/net/core/failover.c > @@ -80,14 +80,14 @@ static int failover_slave_register(struct net_device *slave_dev) > goto err_upper_link; > } > > - slave_dev->priv_flags |= IFF_FAILOVER_SLAVE; > + slave_dev->priv_flags |= (IFF_FAILOVER_SLAVE | IFF_LIVE_NAME_CHANGE); > > if (fops && fops->slave_register && > !fops->slave_register(slave_dev, failover_dev)) > return NOTIFY_OK; > > netdev_upper_dev_unlink(slave_dev, failover_dev); > - slave_dev->priv_flags &= ~IFF_FAILOVER_SLAVE; > + slave_dev->priv_flags &= ~(IFF_FAILOVER_SLAVE | IFF_LIVE_NAME_CHANGE); > err_upper_link: > netdev_rx_handler_unregister(slave_dev); > done: > @@ -121,7 +121,7 @@ int failover_slave_unregister(struct net_device *slave_dev) > > netdev_rx_handler_unregister(slave_dev); > netdev_upper_dev_unlink(slave_dev, failover_dev); > - slave_dev->priv_flags &= ~IFF_FAILOVER_SLAVE; > + slave_dev->priv_flags &= ~(IFF_FAILOVER_SLAVE | IFF_LIVE_NAME_CHANGE); > > if (fops && fops->slave_unregister && > !fops->slave_unregister(slave_dev, failover_dev)) > -- > 1.8.3.1