From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Si-Wei Liu <si-wei.liu@oracle.com>,
sridhar.samudrala@intel.com, davem@davemloft.net, kubakici@wp.pl,
alexander.duyck@gmail.com, jiri@resnulli.us,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, liran.alon@oracle.com,
boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com
Subject: Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces
Date: Fri, 5 Apr 2019 18:01:43 -0400 [thread overview]
Message-ID: <20190405175429-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190405144701.25a6b55b@shemminger-XPS-13-9360>
On Fri, Apr 05, 2019 at 02:47:01PM -0700, Stephen Hemminger wrote:
> On Wed, 3 Apr 2019 00:52:47 -0400
> Si-Wei Liu <si-wei.liu@oracle.com> wrote:
>
> >
> > + if (unlikely(dev->flags & IFF_UP)) {
> > + struct netdev_notifier_change_info change_info = {
> > + .info.dev = dev,
> > + };
> > +
> > + call_netdevice_notifiers_info(NETDEV_CHANGE,
> > + &change_info.info);
> > + }
>
> This notifier is not really necessary, there already is a CHANGENAME
> that gets sent.
> NETDEV_CHANGE is used in other cases to mean that the state (flags)
> have changed.
The point is some existing scripts might not expect name
change to happen without a status change afterwards (since it was
impossible for so long). So this reports a change
to make sure scripts do not miss it.
next prev parent reply other threads:[~2019-04-05 22:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 4:52 [PATCH net v6] failover: allow name change on IFF_UP slave interfaces Si-Wei Liu
2019-04-05 20:40 ` si-wei liu
2019-04-05 21:28 ` Michael S. Tsirkin
2019-04-05 21:28 ` Michael S. Tsirkin
2019-04-05 21:47 ` Stephen Hemminger
2019-04-05 21:47 ` Stephen Hemminger
2019-04-06 7:21 ` si-wei liu
2019-04-07 2:45 ` Samudrala, Sridhar
2019-04-07 2:45 ` Samudrala, Sridhar
2019-04-08 20:56 ` si-wei liu
2019-04-05 21:47 ` Stephen Hemminger
2019-04-05 21:47 ` Stephen Hemminger
2019-04-05 22:01 ` Michael S. Tsirkin [this message]
2019-04-07 15:41 ` Stephen Hemminger
2019-04-07 15:41 ` Stephen Hemminger
2019-04-05 22:01 ` Michael S. Tsirkin
2019-04-05 22:13 ` si-wei liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405175429-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=liran.alon@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=si-wei.liu@oracle.com \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=vijay.balakrishna@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.