From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: FBC needs vblank before enable / disable. Date: Fri, 5 Apr 2019 21:10:10 +0300 Message-ID: <20190405181010.GO3888@intel.com> References: <1554272220-14622-1-git-send-email-kiran.s.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64A5889ED6 for ; Fri, 5 Apr 2019 18:10:16 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1554272220-14622-1-git-send-email-kiran.s.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: kiran.s.kumar@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMDMsIDIwMTkgYXQgMTE6NDc6MDBBTSArMDUzMCwga2lyYW4ucy5rdW1hckBp bnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogS2lyYW4gS3VtYXIgUyA8a2lyYW4ucy5rdW1hckBpbnRl bC5jb3JwLXBhcnRuZXIuZ29vZ2xlLmNvbT4KPiAKPiBBcyBwZXIgdGhlIGRpc3BsYXkgd29ya2Fy b3VuZCAjMTIwMCwgRkJDIG5lZWRzIHdhaXQgZm9yIHZibGFuayBiZWZvcmUKPiBlbmFibGluZyBh bmQgYmVmb3JlIGRpc2FibGluZyBGQkMuCj4gCj4gSW4gc29tZSBjYXNlcywgZGVwZW5kaW5nIG9u IHdoZXRoZXIgRkJDIHdhcyBjb21wcmVzc2luZyBpbiB0aGF0IGZyYW1lLAo+IHNldmVyYWwgY29u dHJvbCBzaWduYWxzIGluIHRoZSBjb21wcmVzc2lvbiBlbmdpbmUgYWxzbyB3aWxsIGZhaWwgdG8K PiBwcm9wZXJseSByZWNvZ25pemUgdGhlIGZpbmFsIHNlZ21lbnQgb2YgdGhlIGZyYW1lIGFzIGEg cmVzdWx0IG9mIHRoZQo+IG1pc3NpbmcgbGFzdCBwaXhlbCBpbmRpY2F0aW9uLiBBcyBhIHJlc3Vs dCBvZiB0aGlzLCB3ZSdyZSBzZWVpbmcKPiBjb3JydXB0ZWQgY2FjaGUgbGluZS9jb21wcmVzc2lv biBpbmRpY2F0b3JzIGFmdGVyIEZCQyByZS1lbmFibGVzCj4gd2hpY2ggY2F1c2VzIHVuZGVycnVu cyBvciBjb3JydXB0aW9uIHdoZW4gdGhleSdyZSB1c2VkIHRvIGRlY29tcHJlc3MuCj4gCj4gV0Eg c2VxdWVuY2UgYXMgYmVsb3c6Cj4gMSkgRGlzcGxheSBlbmFibGVzIHBsYW5lIDFBCj4gMikgV2Fp dCBmb3IgMSB2YmxhbmsKPiAzKSBGQkMgZ2V0cyBlbmFibGVkCj4gNCkgV2FpdCBmb3IgMSBWQkxB TksKPiA1KSBUdXJuIG9mZiBGQkMKPiAKPiBJbiBHTEsgQ2hyb21lIE9TLCBpZiBGQkMgaXMgZW5h YmxlZCBieSBkZWZhdWx0LCBmZXcgdG9wIGxpbmVzIG9uIHRoZSBzY3JlZW4KPiBnb3QgY29ycnVw dGVkLiBXaXRoIHRoZSBhYm92ZSBXQSwgaXNzdWUgd2FzIHJlc29sdmVkLgo+IAo+IENoYW5nZS1J ZDogSThhM2JhZWRhMzYzYjJkMmVjNGU5ZTg2NzNlODkwMTNhMzQxYzY0NmEKPiBTaWduZWQtb2Zm LWJ5OiBLaXJhbiBLdW1hciBTIDxraXJhbi5zLmt1bWFyQGludGVsLmNvcnAtcGFydG5lci5nb29n bGUuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA4 ICsrKysrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggODU3NmE3Zjc5 OWYyLi45MDM2MGRmYzY3NGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gQEAgLTEzMjA3LDggKzEzMjA3LDEyIEBAIHN0YXRpYyB2b2lkIGludGVsX3VwZGF0ZV9jcnRj KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCj4gIAlpZiAocGlwZV9jb25maWctPnVwZGF0ZV9w aXBlICYmICFwaXBlX2NvbmZpZy0+ZW5hYmxlX2ZiYykKPiAgCQlpbnRlbF9mYmNfZGlzYWJsZShp bnRlbF9jcnRjKTsKPiAtCWVsc2UgaWYgKG5ld19wbGFuZV9zdGF0ZSkKPiArCWVsc2UgaWYgKG5l d19wbGFuZV9zdGF0ZSkgewo+ICsJCS8qIERpc3BsYXkgV0EgIzEyMDA6IEdMSyAqLwoKVGhlIHcv YSBkb2Vzbid0IHNlZW0gc3BlY2lmaWMgdG8gZ2xrLgoKPiArCQlpZiAoSVNfR0VNSU5JTEFLRShk ZXZfcHJpdikpCj4gKwkJCWludGVsX3dhaXRfZm9yX3ZibGFuayhkZXZfcHJpdiwgaW50ZWxfY3J0 Yy0+cGlwZSk7CgpEb2luZyB0aGlzIHVuY29kaW50aW9uYWxseSBmb3IgYW55IHBsYW5lIHVwZGF0 ZSBpcyBxdWl0ZSBydWRlLiBXZSBuZWVkCnRvIGxpbWl0IGl0IHRvIGNhc2VzIHdoZXJlIHRoZSBw bGFuZSBpcyBiZWluZyBlbmFibGVkIG9yIGRpc2FibGVkLiBBbmQKc2luY2UgbW9zdCBwbGFuZXMg Y2FuJ3QgZXZlbiBkbyBGQkMgd2Ugc2hvdWxkIG5vdCBoYXZlIHRvIHBheSB0aGUgY29zdApmb3Ig YWxsIHBsYW5lcy4KCj4gIAkJaW50ZWxfZmJjX2VuYWJsZShpbnRlbF9jcnRjLCBwaXBlX2NvbmZp ZywgbmV3X3BsYW5lX3N0YXRlKTsKPiArCX0KPiAgCj4gIAlpbnRlbF9iZWdpbl9jcnRjX2NvbW1p dChjcnRjLCBvbGRfY3J0Y19zdGF0ZSk7Cj4gIAo+IEBAIC0xMzQxOSw2ICsxMzQyMyw4IEBAIHN0 YXRpYyB2b2lkIGludGVsX2F0b21pY19jb21taXRfdGFpbChzdHJ1Y3QgZHJtX2F0b21pY19zdGF0 ZSAqc3RhdGUpCj4gIAo+ICAJCQlkZXZfcHJpdi0+ZGlzcGxheS5jcnRjX2Rpc2FibGUob2xkX2lu dGVsX2NydGNfc3RhdGUsIHN0YXRlKTsKPiAgCQkJaW50ZWxfY3J0Yy0+YWN0aXZlID0gZmFsc2U7 Cj4gKwkJCS8qIERpc3BsYXkgV0EgIzEyMDA6IEdMSyAqLwo+ICsJCQlpbnRlbF93YWl0X2Zvcl92 YmxhbmsoZGV2X3ByaXYsIGludGVsX2NydGMtPnBpcGUpOwoKVGhlIGRpc2FibGUgY2FzZSBzZWVt cyB0byBiZSB3L2EgMTE5OC4gQWxzbyBub3QgZ2xrIHNwZWNpZmljLiBBbHNvLCB0aGlzCmNvZGUg aXMgb25seSB1c2VkIGZvciB0aGUgY2FzZSB3aGVyZSB0aGUgd2hvbGUgcGlwZSBpcyBnZXR0aW5n IGRpc2FibGVkLApzbyB0aGlzIHdvdWxkbid0IGNvdmVyIHRoZSBjYXNlcyB3aGVyZSBqdXN0IHRo ZSBwbGFuZSBpcyBiZWluZwpkaXNhYmxlZC4KCkRvIHdlIGhhdmUgYW55IGlndHMgdGhhdCBleGNl Y2lzZSBwbGFuZSBlbmFibGUvZGlzYWJsZSB2cy4gRkJDPwoKPiAgCQkJaW50ZWxfZmJjX2Rpc2Fi bGUoaW50ZWxfY3J0Yyk7Cj4gIAkJCWludGVsX2Rpc2FibGVfc2hhcmVkX2RwbGwob2xkX2ludGVs X2NydGNfc3RhdGUpOwo+ICAKPiAtLSAKPiAyLjcuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl bApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=