Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Force a full modeset when we force dsc enable

From: Manasi Navare <manasi.d.navare@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Anusha Srivatsa <anusha.srivatsa@intel.com>,
	Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_dp_dsc: Force a full modeset when we force dsc enable
Date: Fri, 5 Apr 2019 11:28:36 -0700	[thread overview]
Message-ID: <20190405182835.GK17236@intel.com> (raw)
In-Reply-To: <20190405100646.GB13716@ideak-desk.fi.intel.com>

On Fri, Apr 05, 2019 at 01:06:46PM +0300, Imre Deak wrote:
> On Thu, Apr 04, 2019 at 04:44:35PM -0700, Manasi Navare wrote:
> > [...]
> > So just call igt_install_exit_handler() without pasisng any function pointer to do
> > just the default cleanups?
> 
> You need to pass it a pointer to a new function you add. The new
> function should write the original value to the debugfs file.

Ok, I had added the restore_value() function to the test_cleanup that I call after update_display()
but yes adding that to the exit handler function would be a good idea.

the test cleanup function that I have now does:
if (data->output) {
igt_plane_set_fb(primary, NULL);
igt_display_commit(&data->display);
igt_remove_fb(data->drm_fd, &data->fb_test_pattern);
}

Hmm, I can still keep this after each test as is correct?

Manasi

> 
> --Imre
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev