From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/ehl: Add support for DPLL4 (v3) Date: Fri, 5 Apr 2019 21:39:11 +0300 Message-ID: <20190405183911.GQ3888@intel.com> References: <20190405000616.32568.75409@emeril.freedesktop.org> <20190405175953.7206-1-vivek.kasireddy@intel.com> <20190405183356.GP3888@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52A53897EE for ; Fri, 5 Apr 2019 18:39:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190405183356.GP3888@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vivek Kasireddy Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBcHIgMDUsIDIwMTkgYXQgMDk6MzM6NTZQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgQXByIDA1LCAyMDE5IGF0IDEwOjU5OjUzQU0gLTA3MDAsIFZpdmVr IEthc2lyZWRkeSB3cm90ZToKPiA+IFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBEUExMNCBv biBFSEwgdGhhdCBpbmNsdWRlIHRoZQo+ID4gZm9sbG93aW5nIHJlc3RyaWN0aW9uczoKPiA+IAo+ ID4gLSBEUExMNCBjYW5ub3QgYmUgdXNlZCB3aXRoIERESUEgKGNvbWJvIHBvcnQgQSBpbnRlcm5h bCBlRFAgdXNhZ2UpLgo+ID4gICBEUExMNCBjYW4gYmUgdXNlZCB3aXRoIG90aGVyIERESXMsIGlu Y2x1ZGluZyBERElECj4gPiAgIChjb21ibyBwb3J0IEEgZXh0ZXJuYWwgdXNhZ2UpLgo+ID4gCj4g PiAtIERQTEw0IGNhbm5vdCBiZSBlbmFibGVkIHdoZW4gREM1IG9yIERDNiBhcmUgZW5hYmxlZC4K PiA+IAo+ID4gLSBUaGUgRFBMTDQgZW5hYmxlLCBsb2NrLCBwb3dlciBlbmFibGVkLCBhbmQgcG93 ZXIgc3RhdGUgYXJlIGNvbm5lY3RlZAo+ID4gICB0byB0aGUgTUdQTEwxX0VOQUJMRSByZWdpc3Rl ci4KPiA+IAo+ID4gdjI6IChzdWdnZXN0aW9ucyBmcm9tIEJvYiBQYWF1d2UpCj4gPiAtIFJld29y ayBlaGxfZ2V0X2RwbGwoKSBmdW5jdGlvbiB0byBjYWxsIGludGVsX2ZpbmRfc2hhcmVkX2RwbGwo KSBhbmQKPiA+ICAgaXRlcmF0ZSB0d2ljZTogb25jZSBmb3IgQ29tYm8gcGxscyBhbmQgb25jZSBm b3IgTUcgcGxscy4KPiA+IAo+ID4gLSBVc2UgTUcgcGxsIGZ1bmNzIGZvciBEUExMNCBpbnN0ZWFk IG9mIGNyZWF0aW5nIG5ldyBvbmVzIGFuZCBtb2RpZnkKPiA+ICAgbWdfcGxsX2VuYWJsZSB0byBp bmNsdWRlIHRoZSByZXN0cmljdGlvbnMgZm9yIEVITC4KPiA+IAo+ID4gdjM6IEZpeCBjb21waWxh dGlvbiBlcnJvcgo+ID4gCj4gPiBDYzogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBp bnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaXZlayBLYXNpcmVkZHkgPHZpdmVrLmthc2ly ZWRkeUBpbnRlbC5jb20+Cj4gPiBSZXZpZXdlZC1ieTogQm9iIFBhYXV3ZSA8Ym9iLmoucGFhdXdl QGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxf bWdyLmMgfCA2MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gIDEgZmls ZSBjaGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+ID4gaW5kZXggZTAxYzA1N2NlNTBiLi5jM2Yw Yjk3MjBjNTQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxs X21nci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4g PiBAQCAtMjg3MCw2ICsyODcwLDU2IEBAIGljbF9nZXRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY3J0Y19zdGF0ZSwKPiA+ICAJcmV0dXJuIHBsbDsKPiA+ICB9Cj4gPiAgCj4gPiArc3Rh dGljIHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqCj4gPiArZWhsX2dldF9kcGxsKHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ID4gKwkgICAgIHN0cnVjdCBpbnRlbF9lbmNv ZGVyICplbmNvZGVyKQo+ID4gK3sKPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gdG9faTkxNShjcnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldik7Cj4gPiArCXN0cnVjdCBp bnRlbF9zaGFyZWRfZHBsbCAqcGxsOwo+ID4gKwllbnVtIHBvcnQgcG9ydCA9IGVuY29kZXItPnBv cnQ7Cj4gPiArCWVudW0gaW50ZWxfZHBsbF9pZCBtaW4sIG1heDsKPiA+ICsJYm9vbCByZXQ7Cj4g PiArCj4gPiArCWlmICghaW50ZWxfcG9ydF9pc19jb21ib3BoeShkZXZfcHJpdiwgcG9ydCkpIHsK PiA+ICsJCU1JU1NJTkdfQ0FTRShwb3J0KTsKPiA+ICsJCXJldHVybiBOVUxMOwo+ID4gKwl9Cj4g PiArCj4gPiArCW1pbiA9IERQTExfSURfSUNMX0RQTEwwOwo+ID4gKwltYXggPSBEUExMX0lEX0lD TF9EUExMMTsKPiA+ICsJcmV0ID0gaWNsX2NhbGNfZHBsbF9zdGF0ZShjcnRjX3N0YXRlLCBlbmNv ZGVyKTsKPiA+ICsJaWYgKHJldCkgewo+ID4gKwkJcGxsID0gaW50ZWxfZmluZF9zaGFyZWRfZHBs bChjcnRjX3N0YXRlLCBtaW4sIG1heCk7Cj4gPiArCQlpZiAocGxsKSB7Cj4gPiArCQkJaW50ZWxf cmVmZXJlbmNlX3NoYXJlZF9kcGxsKHBsbCwgY3J0Y19zdGF0ZSk7Cj4gPiArCQkJcmV0dXJuIHBs bDsKPiA+ICsJCX0KPiA+ICsJfSBlbHNlIHsKPiA+ICsJCURSTV9ERUJVR19LTVMoIkNvdWxkIG5v dCBjYWxjdWxhdGUgUExMIHN0YXRlLlxuIik7Cj4gPiArCX0KPiA+ICsKPiA+ICsJaWYgKGVuY29k ZXItPnR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCkgewo+ID4gKwkJRFJNX0RFQlVHX0tNUygiQ2Fu bm90IHVzZSBEUExMNCB3aXRoIEVEUC5cbiIpOwo+ID4gKwkJcmV0dXJuIE5VTEw7Cj4gPiArCX0K PiA+ICsKPiA+ICsJbWluID0gbWF4ID0gRFBMTF9JRF9JQ0xfTUdQTEwxOwo+ID4gKwlyZXQgPSBp Y2xfY2FsY19tZ19wbGxfc3RhdGUoY3J0Y19zdGF0ZSk7Cj4gPiArCWlmICghcmV0KSB7Cj4gPiAr CQlEUk1fREVCVUdfS01TKCJDb3VsZCBub3QgY2FsY3VsYXRlIFBMTCBzdGF0ZS5cbiIpOwo+ID4g KwkJcmV0dXJuIE5VTEw7Cj4gPiArCX0KPiA+ICsKPiA+ICsJcGxsID0gaW50ZWxfZmluZF9zaGFy ZWRfZHBsbChjcnRjX3N0YXRlLCBtaW4sIG1heCk7Cj4gPiArCWlmICghcGxsKSB7Cj4gPiArCQlE Uk1fREVCVUdfS01TKCJObyBQTEwgc2VsZWN0ZWRcbiIpOwo+ID4gKwkJcmV0dXJuIE5VTEw7Cj4g PiArCX0KPiA+ICsKPiA+ICsJaW50ZWxfcmVmZXJlbmNlX3NoYXJlZF9kcGxsKHBsbCwgY3J0Y19z dGF0ZSk7Cj4gPiArCXJldHVybiBwbGw7Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyBib29sIG1n X3BsbF9nZXRfaHdfc3RhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4g IAkJCQlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCwKPiA+ICAJCQkJc3RydWN0IGludGVs X2RwbGxfaHdfc3RhdGUgKmh3X3N0YXRlKQo+ID4gQEAgLTMxMTUsNiArMzE2NSwxMyBAQCBzdGF0 aWMgdm9pZCBtZ19wbGxfZW5hYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK PiA+ICAJaTkxNV9yZWdfdCBlbmFibGVfcmVnID0KPiA+ICAJCU1HX1BMTF9FTkFCTEUoaWNsX3Bs bF9pZF90b190Y19wb3J0KHBsbC0+aW5mby0+aWQpKTsKPiA+ICAKPiA+ICsJaWYgKElTX0VMS0hB UlRMQUtFKGRldl9wcml2KSAmJgo+ID4gKwkgICAoSTkxNV9SRUFEKERDX1NUQVRFX0VOKSAmIERD X1NUQVRFX0VOX1VQVE9fREM1IHx8Cj4gPiArCSAgICBJOTE1X1JFQUQoRENfU1RBVEVfRU4pICYg RENfU1RBVEVfRU5fVVBUT19EQzYpKSB7Cj4gPiArCQlEUk1fRVJST1IoIkNhbnQgZW5hYmxlIERQ TEw0IHdoZW4gREM1IG9yIERDNiBhcmUgZW5hYmxlZFxuIik7Cj4gPiArCQlyZXR1cm47Cj4gPiAr CX0KPiAKPiBUaGlzIGxvb2tzIGxpa2UgZGVhZCBjb2RlLCBvciB3ZSBtZXNzZWQgdXAgZWFybGll ciBhbHJlYWR5IChpbiB3aGljaAo+IGNhc2UgaXQgc2hvdWxkIGp1c3QgYmUgc29tZSBraW5kIG9m IGFzc2VydCBJTU8pLgoKRG9lcyBETUMgaGFuZGxlIG90aGVyIE1HIFBMTHM/IEkgd291bGQgaGF2 ZSB0aG91Z2h0IG5vdCwgc28gaWYgd2Uga2VlcAp0aGUgYXNzZXJ0IHRoZW4gaXQgc2hvdWxkIHBl cmhhcHMgYmUgdW5jb25kaXRpb25hbC4gSG1tLiBCdXQgYXJlbid0IHdlCnN0aWxsIGhvZGxpbmcg dGhlIG1vZGVzZXQgcG93ZXIgZG9tYWluIHdoZW4gdGhpcyBnZXRzIGNhbGxlZD8gSWYgc28gdGhp cwppcyBkZWZpbml0ZWx5IGRlYWQgY29kZS4KCj4gCj4gQWxzbyB3aGF0IGlzIHRoaXMgRUhMIHRo aW5nIGFueXdheT8gSSBjYW4ndCBldmVuIGZpbmQgaXQgaW4gdGhlIHNwZWMuCj4gCj4gPiArCj4g PiAgCWljbF9wbGxfcG93ZXJfZW5hYmxlKGRldl9wcml2LCBwbGwsIGVuYWJsZV9yZWcpOwo+ID4g IAo+ID4gIAlpY2xfbWdfcGxsX3dyaXRlKGRldl9wcml2LCBwbGwpOwo+ID4gQEAgLTMyNDksMTIg KzMzMDYsMTMgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBpbnRlbF9kcGxsX21nciBpY2xfcGxsX21n ciA9IHsKPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRwbGxfaW5mbyBlaGxfcGxsc1tdID0gewo+ ID4gIAl7ICJEUExMIDAiLCAmY29tYm9fcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9EUExMMCwgMCB9 LAo+ID4gIAl7ICJEUExMIDEiLCAmY29tYm9fcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9EUExMMSwg MCB9LAo+ID4gKwl7ICJEUExMIDQiLCAmbWdfcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9NR1BMTDEs MCB9LAo+ID4gIAl7IH0sCj4gPiAgfTsKPiA+ICAKPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGlu dGVsX2RwbGxfbWdyIGVobF9wbGxfbWdyID0gewo+ID4gIAkuZHBsbF9pbmZvID0gZWhsX3BsbHMs Cj4gPiAtCS5nZXRfZHBsbCA9IGljbF9nZXRfZHBsbCwKPiA+ICsJLmdldF9kcGxsID0gZWhsX2dl dF9kcGxsLAo+ID4gIAkuZHVtcF9od19zdGF0ZSA9IGljbF9kdW1wX2h3X3N0YXRlLAo+ID4gIH07 Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMTQuNQo+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiAKPiAtLSAKPiBWaWxsZSBTeXJq w6Rsw6QKPiBJbnRlbAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=