All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, samuel.thibault@ens-lyon.org,
	jan.kiszka@siemens.com
Subject: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix
Date: Fri,  5 Apr 2019 19:46:48 +0100	[thread overview]
Message-ID: <20190405184648.17029-1-dgilbert@redhat.com> (raw)

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Gcc 9 needs some convincing that sopreprbuf really is going to fill
in iov in the call from soreadbuf, even though the failure case
shouldn't happen; so swing the check around initialising the fields.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 slirp/src/socket.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/slirp/src/socket.c b/slirp/src/socket.c
index 4a3c935e25..4a2222a95f 100644
--- a/slirp/src/socket.c
+++ b/slirp/src/socket.c
@@ -113,12 +113,14 @@ size_t sopreprbuf(struct socket *so, struct iovec *iov, int *np)
 	DEBUG_CALL("sopreprbuf");
 	DEBUG_ARG("so = %p", so);
 
-	if (len <= 0)
-		return 0;
-
 	iov[0].iov_base = sb->sb_wptr;
+        iov[0].iov_len = 0;
         iov[1].iov_base = NULL;
         iov[1].iov_len = 0;
+
+	if (len <= 0)
+		return 0;
+
 	if (sb->sb_wptr < sb->sb_rptr) {
 		iov[0].iov_len = sb->sb_rptr - sb->sb_wptr;
 		/* Should never succeed, but... */
-- 
2.21.0

             reply	other threads:[~2019-04-05 19:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 18:46 Dr. David Alan Gilbert (git) [this message]
2019-04-05 19:08 ` [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix no-reply
2019-04-05 19:08   ` no-reply
2019-04-05 21:25 ` Samuel Thibault
2019-04-05 21:25   ` Samuel Thibault
2019-04-08  8:46   ` Dr. David Alan Gilbert
2019-04-08  8:46     ` Dr. David Alan Gilbert
2019-04-11 18:45     ` Samuel Thibault
2019-04-11 18:45       ` Samuel Thibault
2019-04-12 15:49       ` Dr. David Alan Gilbert
2019-04-12 15:49         ` Dr. David Alan Gilbert
2019-04-12 21:16         ` Samuel Thibault
2019-04-12 21:16           ` Samuel Thibault
2019-04-15 12:02           ` Dr. David Alan Gilbert
2019-04-15 12:02             ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405184648.17029-1-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.