From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Tomas Bortoli <tomasbortoli@gmail.com>
Subject: Re: [Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META packet carefully
Date: Fri, 5 Apr 2019 23:09:29 +0300 [thread overview]
Message-ID: <20190405200929.GV32613@kadam> (raw)
In-Reply-To: <CAM_iQpXnPyqGxgPF19CA9n=DGYmJ9d-Vn4fvu1kKunonPKpW6A@mail.gmail.com>
As I explained in my email, the original code is buggy if
num_reports > 1 (probably uncommon), but your code is buggy for
num_reports >= 1 (everything).
regards,
dan carpenter
next prev parent reply other threads:[~2019-04-05 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 23:08 [Patch net v2 0/3] bluetooth: validate packet boundary carefully Cong Wang
2019-04-03 23:08 ` [Patch net v2 1/3] bluetooth: validate HCI_EVENT_PKT packet carefully Cong Wang
2019-04-23 19:42 ` Marcel Holtmann
2019-04-24 1:36 ` Cong Wang
2019-04-03 23:08 ` [Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META " Cong Wang
2019-04-04 8:34 ` Dan Carpenter
2019-04-05 17:26 ` Cong Wang
2019-04-05 20:09 ` Dan Carpenter [this message]
2019-04-03 23:08 ` [Patch net v2 3/3] bluetooth: validate HCI_EV_CMD_COMPLETE " Cong Wang
-- strict thread matches above, loose matches on Subject: below --
2019-03-21 6:12 [Patch net v2 0/3] bluetooth: validate packet boundary carefully Cong Wang
2019-03-21 6:12 ` [Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META packet carefully Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405200929.GV32613@kadam \
--to=dan.carpenter@oracle.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=tomasbortoli@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.