From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=n03X=SH=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3A5C282CE
	for <netdev@archiver.kernel.org>; Fri,  5 Apr 2019 22:08:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 4F5A12171F
	for <netdev@archiver.kernel.org>; Fri,  5 Apr 2019 22:08:52 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="R2VgEib5"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726360AbfDEWIv (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 5 Apr 2019 18:08:51 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:52083 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726124AbfDEWIv (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 5 Apr 2019 18:08:51 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=L8KsfEjEdHWpEMthRsbpa/Vvk+8s8QjtT/svHkuH8Pc=; b=R2VgEib5sSiIvfmpjssDGeNBl1
        3hKC/Rh4O/VRqzuc36RFDOQJsrx9L/xcaUQ4jU6oUHRoYjJnY6e9poiqP+jk1Nk5rcutQkrlgoqjC
        k36fJ30jeqtb0/P4v7gm7nV/0K6/JsODjKVp//njJws10M3jys2YkpRPtqu9W2YOAPQM=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hCWN4-0007MB-Pt; Fri, 05 Apr 2019 23:27:34 +0200
Date:   Fri, 5 Apr 2019 23:27:34 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve link partner capability
 detection
Message-ID: <20190405212734.GE27350@lunn.ch>
References: <ba751e0e-7fa1-d687-24ac-303c5f54c08f@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ba751e0e-7fa1-d687-24ac-303c5f54c08f@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> +	if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT,
> +			      phydev->supported))
> +		phydev->is_gigabit_capable = 1;
> +	if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT,
> +			      phydev->supported))
> +		phydev->is_gigabit_capable = 1;
> +

What i'm trying to get at is, why do we need this bit of the patch?
Why do we need this flag? The hardware should tell us if it can do
gigabit.

	Andrew