From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32AF2C10F06 for ; Sat, 6 Apr 2019 14:15:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02605213A2 for ; Sat, 6 Apr 2019 14:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554560114; bh=1wI3dTqhLTBWJogQ6POsb00j+qUWV+SPop4ILSpc0LA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=avSgLXQotbDelXc11i6Hm/53ZBG80jGy14dxvTyWCsqcQaTfEleXFsDTrZbhKAzr4 WLJnXUMVcFleS8JBkYt9Z0N4X9vm0WUrnG5dMt+QfAOZIWAmgtdqaWhQYggwYWIVWa 74s7kDBDi7zdsH4dzFY75Jpgp3wQvxunoX5U3n9E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbfDFOPM (ORCPT ); Sat, 6 Apr 2019 10:15:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:52376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbfDFOPM (ORCPT ); Sat, 6 Apr 2019 10:15:12 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADD322146F; Sat, 6 Apr 2019 14:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554560112; bh=1wI3dTqhLTBWJogQ6POsb00j+qUWV+SPop4ILSpc0LA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=12cx3FyCPHWmSV9SFCth+nT5YicHFGeV8qL6nx8dueLVmQfCi8M2crmw2obVWkz5g IfVP8CLMY3heqazsl2i1XBodmZXTGIv3YRBO/jOEjeNzK9gEEWypsuu+D+qyK7OAjt 7AQAPYiCZy0lxjXatujeJBWNRrVjySZqmkP4iM6g= Date: Sat, 6 Apr 2019 10:15:10 -0400 From: Sasha Levin To: Captain Wiggum , davem@davemloft.net Cc: Greg Kroah-Hartman , Florian Westphal , Eric Dumazet , Peter Oskolkov , netdev@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu Message-ID: <20190406141510.GC2935@sasha-vm> References: <20190405045047.GB553@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 05, 2019 at 10:22:51AM -0600, Captain Wiggum wrote: >I know it affects 4.9, 4.14, 4.19. >I have not tested the older LTS kernels. >But any LTS kernel that previously received this commit is affected: >... commit a8444b1ccb20339774af58e40ad42296074fb484 >... ipv6: defrag: drop non-last frags smaller than min mtu > > > >On Thu, Apr 4, 2019 at 10:50 PM Greg Kroah-Hartman > wrote: >> >> On Thu, Apr 04, 2019 at 06:18:30PM -0600, Captain Wiggum wrote: >> > Hi Greg, >> > >> > A previous bad patch breaks 18 test cases for IPv6 fragment headers. >> > This has already been un-done in upstream, but not in any of the LTS. >> > However two upstream patches are first needed to cover a DoS vulnerability. >> > >> > For background, there are two mail threads in [netdev] on this subject: >> > 1) Subject: TAHI testing fails for IPv6 Fragments in Kernel 4.9 (from >> > captwiggum) >> > 2) Subject: Please merge IPv6 fix for drop fragment smaller than MTU >> > (from captwiggum) >> > >> > Two patches from upstream needed first to cover the DoS: >> > >> > commit d4289fcc9b16b89619ee1c54f829e05e56de8b9a >> > net: IP6 defrag: use rbtrees for IPv6 defrag >> > >> > commit 997dd96471641e147cb2c33ad54284000d0f5e35 >> > net: IP6 defrag: use rbtrees in nf_conntrack_reasm.c >> > >> > One undo-patch to fix the IPv6 fragment headers: >> > >> > ipv6: defrag: drop non-last frags smaller than min mtu >> > UN-DO: commit a8444b1ccb20339774af58e40ad42296074fb484 >> >> For what kernel version(s) do these patches need to be applied? >> >> thanks, >> >> greg k-h I see that 0ed4229b08c1 ("ipv6: defrag: drop non-last frags smaller than min mtu") wasn't reverted upstream, why is a revert needed on the stable trees? David, could you ack these requests? -- Thanks, Sasha