All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] infra/Makefile.in: Fix format_arg issues after bump gettext-tiny to c6dcdcd
Date: Sat, 6 Apr 2019 22:53:56 +0200	[thread overview]
Message-ID: <20190406205356.GE2659@scaer> (raw)
In-Reply-To: <20190404230503.ohxfkac6extrghuv@vkochan-ThinkPad-T470p>

Vadim, All,

On 2019-04-05 02:05 +0300, Vadim Kochan spake thusly:
> On Fri, Apr 05, 2019 at 01:47:00AM +0300, Vadim Kochan wrote:
> > After bump gettext-tiny to c6dcdcd there was change which enabled
> > gettext's macroses by default in:
> > 
> >     https://github.com/sabotage-linux/gettext-tiny/commit/58187329ad9f00eb8c39379e7ee0b608dd14bab8
> > 
> > it leads libglib2 to fail with format_arg issues. So fix it by disabling
> > these macroses and use rather external functions which requires linking.
> > 
> > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > ---
> > I dont feel like this is a good solution actually. I need to clearly understand
> > why just using gettext's macrosses does not work for libglib2. But anyway I am
> > sending this patch to show the possible solution.
[--SNIP--]
> I think that may be package/Makefile.in is not good place for this but
> better to add another patch which will disable these macrosses ?

Indeed, I don;t think this is th3e correct fix.

Instead, I suggest we use what upstream did apply very recently:
    https://github.com/sabotage-linux/gettext-tiny/commit/73fc3e7ef7e016a3874b632fd0475969d288f309

Oh, wait, that name rings a bell... ;-)

Can you send a bump to gettext-tiny, now? ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2019-04-06 20:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 22:47 [Buildroot] [PATCH 1/1] infra/Makefile.in: Fix format_arg issues after bump gettext-tiny to c6dcdcd Vadim Kochan
2019-04-04 23:05 ` Vadim Kochan
2019-04-06 20:53   ` Yann E. MORIN [this message]
2019-04-06 21:05     ` Yann E. MORIN
2019-04-06 21:24       ` Vadim Kochan
2019-04-07  7:01         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190406205356.GE2659@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.