All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Jiufei Xue <jiufei.xue@linux.alibaba.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz, renzhen@linux.alibaba.com
Subject: Re: [PATCH v2] jbd2: check superblock mapped prior to committing
Date: Sat, 6 Apr 2019 19:03:52 -0400	[thread overview]
Message-ID: <20190406230352.GG18897@mit.edu> (raw)
In-Reply-To: <20190328100750.71045-1-jiufei.xue@linux.alibaba.com>

On Thu, Mar 28, 2019 at 06:07:50PM +0800, Jiufei Xue wrote:
> We hit a BUG at fs/buffer.c:3057 if we detached the nbd device
> before unmounting ext4 filesystem.
> 
> The typical chain of events leading to the BUG:
> jbd2_write_superblock
>   submit_bh
>     submit_bh_wbc
>       BUG_ON(!buffer_mapped(bh));
> 
> The block device is removed and all the pages are invalidated. JBD2
> was trying to write journal superblock to the block device which is
> no longer present.
> 
> Fix this by checking the journal superblock's buffer head prior to
> submitting.

Thanks, applied.

					- Ted

      parent reply	other threads:[~2019-04-07  2:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 10:07 [PATCH v2] jbd2: check superblock mapped prior to committing Jiufei Xue
2019-04-02  4:11 ` Jiufei Xue
2019-04-02  7:43   ` Jan Kara
2019-04-06 23:03 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190406230352.GG18897@mit.edu \
    --to=tytso@mit.edu \
    --cc=jack@suse.cz \
    --cc=jiufei.xue@linux.alibaba.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=renzhen@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.