From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] cmd: Add 'bcb' command to read/modify/write BCB fields
Date: Mon, 8 Apr 2019 00:43:39 +0200 [thread overview]
Message-ID: <20190407224339.GA9481@x230> (raw)
In-Reply-To: <19665b50-6d52-fc96-0612-f1f390ecd88f@gmx.de>
Hi Heinrich,
On Mon, Apr 08, 2019 at 12:11:59AM +0200, Heinrich Schuchardt wrote:
[..]
> > + switch (bcb_cmd_get(argv[0])) {
> > + case BCB_CMD_LOAD:
> > + return bcb_load(argc, argv, &bcb, &bcb_dev, &bcb_part);
> > + case BCB_CMD_FIELD_SET:
> > + return bcb_field_set(argc, argv, &bcb, bcb_dev, bcb_part);
> > + case BCB_CMD_FIELD_CLEAR:
> > + return bcb_field_clear(argc, argv, &bcb, bcb_dev, bcb_part);
> > + case BCB_CMD_FIELD_TEST:
> > + return bcb_field_test(argc, argv, &bcb, bcb_dev, bcb_part);
> > + case BCB_CMD_FIELD_DUMP:
> > + return bcb_field_dump(argc, argv, &bcb, bcb_dev, bcb_part);
> > + case BCB_CMD_STORE:
> > + return bcb_store(argc, argv, &bcb, bcb_dev, bcb_part);
> > + default:
> > + return CMD_RET_USAGE;
> > + }
>
> Please, implement the sub-commands as described in doc/README.commands
> using the U_BOOT_CMD_MKENT macro.
Thanks for the lightning-fast reply. Will fix in v2, once hopefully
more review comments are collected.
> Best regards
>
> Heinrich
Best regards,
Eugeniu.
next prev parent reply other threads:[~2019-04-07 22:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 22:02 [U-Boot] [PATCH 0/2] Add 'bcb' command to read/modify/write Android BCB Eugeniu Rosca
2019-04-07 22:02 ` [U-Boot] [PATCH 1/2] include: android_bl_msg.h: Initial import Eugeniu Rosca
2019-05-08 14:26 ` Sam Protsenko
2019-05-08 14:45 ` Eugeniu Rosca
2019-05-08 17:25 ` Sam Protsenko
2019-05-09 1:41 ` Eugeniu Rosca
2019-05-10 14:23 ` Sam Protsenko
2019-05-10 19:40 ` Eugeniu Rosca
2019-05-08 14:38 ` Sam Protsenko
2019-05-08 17:40 ` Tom Rini
2019-04-07 22:02 ` [U-Boot] [PATCH 2/2] cmd: Add 'bcb' command to read/modify/write BCB fields Eugeniu Rosca
2019-04-07 22:11 ` Heinrich Schuchardt
2019-04-07 22:43 ` Eugeniu Rosca [this message]
2019-05-17 15:05 ` [U-Boot] [PATCH 0/2] Add 'bcb' command to read/modify/write Android BCB Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190407224339.GA9481@x230 \
--to=roscaeugeniu@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.