From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/ehl: Add support for DPLL4 (v3) Date: Mon, 8 Apr 2019 12:11:15 +0300 Message-ID: <20190408091115.GX3888@intel.com> References: <20190405000616.32568.75409@emeril.freedesktop.org> <20190405175953.7206-1-vivek.kasireddy@intel.com> <20190405183356.GP3888@intel.com> <20190405183911.GQ3888@intel.com> <20190405163330.0b116e9d@vkasired-desk2.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 214C7896C4 for ; Mon, 8 Apr 2019 09:11:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190405163330.0b116e9d@vkasired-desk2.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vivek Kasireddy Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBcHIgMDUsIDIwMTkgYXQgMDQ6MzM6MzBQTSAtMDcwMCwgVml2ZWsgS2FzaXJlZGR5 IHdyb3RlOgo+IE9uIEZyaSwgNSBBcHIgMjAxOSAyMTozOToxMSArMDMwMAo+IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+IEhpIFZpbGxlLAo+ IAo+ID4gT24gRnJpLCBBcHIgMDUsIDIwMTkgYXQgMDk6MzM6NTZQTSArMDMwMCwgVmlsbGUgU3ly asOkbMOkIHdyb3RlOgo+ID4gPiBPbiBGcmksIEFwciAwNSwgMjAxOSBhdCAxMDo1OTo1M0FNIC0w NzAwLCBWaXZlayBLYXNpcmVkZHkgd3JvdGU6ICAKPiA+ID4gPiBUaGlzIHBhdGNoIGFkZHMgc3Vw cG9ydCBmb3IgRFBMTDQgb24gRUhMIHRoYXQgaW5jbHVkZSB0aGUKPiA+ID4gPiBmb2xsb3dpbmcg cmVzdHJpY3Rpb25zOgo+ID4gPiA+IAo+ID4gPiA+IC0gRFBMTDQgY2Fubm90IGJlIHVzZWQgd2l0 aCBERElBIChjb21ibyBwb3J0IEEgaW50ZXJuYWwgZURQCj4gPiA+ID4gdXNhZ2UpLiBEUExMNCBj YW4gYmUgdXNlZCB3aXRoIG90aGVyIERESXMsIGluY2x1ZGluZyBERElECj4gPiA+ID4gICAoY29t Ym8gcG9ydCBBIGV4dGVybmFsIHVzYWdlKS4KPiA+ID4gPiAKPiA+ID4gPiAtIERQTEw0IGNhbm5v dCBiZSBlbmFibGVkIHdoZW4gREM1IG9yIERDNiBhcmUgZW5hYmxlZC4KPiA+ID4gPiAKPiA+ID4g PiAtIFRoZSBEUExMNCBlbmFibGUsIGxvY2ssIHBvd2VyIGVuYWJsZWQsIGFuZCBwb3dlciBzdGF0 ZSBhcmUKPiA+ID4gPiBjb25uZWN0ZWQgdG8gdGhlIE1HUExMMV9FTkFCTEUgcmVnaXN0ZXIuCj4g PiA+ID4gCj4gPiA+ID4gdjI6IChzdWdnZXN0aW9ucyBmcm9tIEJvYiBQYWF1d2UpCj4gPiA+ID4g LSBSZXdvcmsgZWhsX2dldF9kcGxsKCkgZnVuY3Rpb24gdG8gY2FsbCBpbnRlbF9maW5kX3NoYXJl ZF9kcGxsKCkKPiA+ID4gPiBhbmQgaXRlcmF0ZSB0d2ljZTogb25jZSBmb3IgQ29tYm8gcGxscyBh bmQgb25jZSBmb3IgTUcgcGxscy4KPiA+ID4gPiAKPiA+ID4gPiAtIFVzZSBNRyBwbGwgZnVuY3Mg Zm9yIERQTEw0IGluc3RlYWQgb2YgY3JlYXRpbmcgbmV3IG9uZXMgYW5kCj4gPiA+ID4gbW9kaWZ5 IG1nX3BsbF9lbmFibGUgdG8gaW5jbHVkZSB0aGUgcmVzdHJpY3Rpb25zIGZvciBFSEwuCj4gPiA+ ID4gCj4gPiA+ID4gdjM6IEZpeCBjb21waWxhdGlvbiBlcnJvcgo+ID4gPiA+IAo+ID4gPiA+IENj OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiA+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBWaXZlayBLYXNpcmVkZHkgPHZpdmVrLmthc2lyZWRkeUBpbnRlbC5jb20+Cj4g PiA+ID4gUmV2aWV3ZWQtYnk6IEJvYiBQYWF1d2UgPGJvYi5qLnBhYXV3ZUBpbnRlbC5jb20+Cj4g PiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMg fCA2MAo+ID4gPiA+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystIDEgZmlsZSBj aGFuZ2VkLCA1OQo+ID4gPiA+IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gPiAK PiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3Iu Ywo+ID4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyBpbmRleAo+ ID4gPiA+IGUwMWMwNTdjZTUwYi4uYzNmMGI5NzIwYzU0IDEwMDY0NCAtLS0KPiA+ID4gPiBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgKysrCj4gPiA+ID4gYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIEBAIC0yODcwLDYgKzI4NzAsNTYgQEAKPiA+ ID4gPiBpY2xfZ2V0X2RwbGwoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsIHJl dHVybiBwbGw7Cj4gPiA+ID4gIH0KPiA+ID4gPiAgCj4gPiA+ID4gK3N0YXRpYyBzdHJ1Y3QgaW50 ZWxfc2hhcmVkX2RwbGwgKgo+ID4gPiA+ICtlaGxfZ2V0X2RwbGwoc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUsCj4gPiA+ID4gKwkgICAgIHN0cnVjdCBpbnRlbF9lbmNvZGVyICpl bmNvZGVyKQo+ID4gPiA+ICt7Cj4gPiA+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPQo+ID4gPiA+IHRvX2k5MTUoY3J0Y19zdGF0ZS0+YmFzZS5jcnRjLT5kZXYpOwo+ID4g PiA+ICsJc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGw7Cj4gPiA+ID4gKwllbnVtIHBvcnQg cG9ydCA9IGVuY29kZXItPnBvcnQ7Cj4gPiA+ID4gKwllbnVtIGludGVsX2RwbGxfaWQgbWluLCBt YXg7Cj4gPiA+ID4gKwlib29sIHJldDsKPiA+ID4gPiArCj4gPiA+ID4gKwlpZiAoIWludGVsX3Bv cnRfaXNfY29tYm9waHkoZGV2X3ByaXYsIHBvcnQpKSB7Cj4gPiA+ID4gKwkJTUlTU0lOR19DQVNF KHBvcnQpOwo+ID4gPiA+ICsJCXJldHVybiBOVUxMOwo+ID4gPiA+ICsJfQo+ID4gPiA+ICsKPiA+ ID4gPiArCW1pbiA9IERQTExfSURfSUNMX0RQTEwwOwo+ID4gPiA+ICsJbWF4ID0gRFBMTF9JRF9J Q0xfRFBMTDE7Cj4gPiA+ID4gKwlyZXQgPSBpY2xfY2FsY19kcGxsX3N0YXRlKGNydGNfc3RhdGUs IGVuY29kZXIpOwo+ID4gPiA+ICsJaWYgKHJldCkgewo+ID4gPiA+ICsJCXBsbCA9IGludGVsX2Zp bmRfc2hhcmVkX2RwbGwoY3J0Y19zdGF0ZSwgbWluLAo+ID4gPiA+IG1heCk7Cj4gPiA+ID4gKwkJ aWYgKHBsbCkgewo+ID4gPiA+ICsJCQlpbnRlbF9yZWZlcmVuY2Vfc2hhcmVkX2RwbGwocGxsLAo+ ID4gPiA+IGNydGNfc3RhdGUpOwo+ID4gPiA+ICsJCQlyZXR1cm4gcGxsOwo+ID4gPiA+ICsJCX0K PiA+ID4gPiArCX0gZWxzZSB7Cj4gPiA+ID4gKwkJRFJNX0RFQlVHX0tNUygiQ291bGQgbm90IGNh bGN1bGF0ZSBQTEwKPiA+ID4gPiBzdGF0ZS5cbiIpOwo+ID4gPiA+ICsJfQo+ID4gPiA+ICsKPiA+ ID4gPiArCWlmIChlbmNvZGVyLT50eXBlID09IElOVEVMX09VVFBVVF9FRFApIHsKPiA+ID4gPiAr CQlEUk1fREVCVUdfS01TKCJDYW5ub3QgdXNlIERQTEw0IHdpdGggRURQLlxuIik7Cj4gPiA+ID4g KwkJcmV0dXJuIE5VTEw7Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gKwo+ID4gPiA+ICsJbWluID0gbWF4 ID0gRFBMTF9JRF9JQ0xfTUdQTEwxOwo+ID4gPiA+ICsJcmV0ID0gaWNsX2NhbGNfbWdfcGxsX3N0 YXRlKGNydGNfc3RhdGUpOwo+ID4gPiA+ICsJaWYgKCFyZXQpIHsKPiA+ID4gPiArCQlEUk1fREVC VUdfS01TKCJDb3VsZCBub3QgY2FsY3VsYXRlIFBMTAo+ID4gPiA+IHN0YXRlLlxuIik7Cj4gPiA+ ID4gKwkJcmV0dXJuIE5VTEw7Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gKwo+ID4gPiA+ICsJcGxsID0g aW50ZWxfZmluZF9zaGFyZWRfZHBsbChjcnRjX3N0YXRlLCBtaW4sIG1heCk7Cj4gPiA+ID4gKwlp ZiAoIXBsbCkgewo+ID4gPiA+ICsJCURSTV9ERUJVR19LTVMoIk5vIFBMTCBzZWxlY3RlZFxuIik7 Cj4gPiA+ID4gKwkJcmV0dXJuIE5VTEw7Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gKwo+ID4gPiA+ICsJ aW50ZWxfcmVmZXJlbmNlX3NoYXJlZF9kcGxsKHBsbCwgY3J0Y19zdGF0ZSk7Cj4gPiA+ID4gKwly ZXR1cm4gcGxsOwo+ID4gPiA+ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ICBzdGF0aWMgYm9vbCBtZ19w bGxfZ2V0X2h3X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gPiA+ID4gKmRldl9wcml2 LCBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCwKPiA+ID4gPiAgCQkJCXN0cnVjdCBpbnRl bF9kcGxsX2h3X3N0YXRlCj4gPiA+ID4gKmh3X3N0YXRlKSBAQCAtMzExNSw2ICszMTY1LDEzIEBA IHN0YXRpYyB2b2lkCj4gPiA+ID4gbWdfcGxsX2VuYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsIGk5MTVfcmVnX3QKPiA+ID4gPiBlbmFibGVfcmVnID0gTUdfUExMX0VOQUJM RShpY2xfcGxsX2lkX3RvX3RjX3BvcnQocGxsLT5pbmZvLT5pZCkpOwo+ID4gPiA+ICAKPiA+ID4g PiArCWlmIChJU19FTEtIQVJUTEFLRShkZXZfcHJpdikgJiYKPiA+ID4gPiArCSAgIChJOTE1X1JF QUQoRENfU1RBVEVfRU4pICYgRENfU1RBVEVfRU5fVVBUT19EQzUgfHwKPiA+ID4gPiArCSAgICBJ OTE1X1JFQUQoRENfU1RBVEVfRU4pICYgRENfU1RBVEVfRU5fVVBUT19EQzYpKSB7Cj4gPiA+ID4g KwkJRFJNX0VSUk9SKCJDYW50IGVuYWJsZSBEUExMNCB3aGVuIERDNSBvciBEQzYgYXJlCj4gPiA+ ID4gZW5hYmxlZFxuIik7Cj4gPiA+ID4gKwkJcmV0dXJuOwo+ID4gPiA+ICsJfSAgCj4gPiA+IAo+ ID4gPiBUaGlzIGxvb2tzIGxpa2UgZGVhZCBjb2RlLCBvciB3ZSBtZXNzZWQgdXAgZWFybGllciBh bHJlYWR5IChpbiB3aGljaAo+ID4gPiBjYXNlIGl0IHNob3VsZCBqdXN0IGJlIHNvbWUga2luZCBv ZiBhc3NlcnQgSU1PKS4gIAo+IEFyZSB5b3Ugc3VnZ2VzdGluZyB0aGF0IEkgcHV0IHRoaXMgaW4g YSAtPnByZXBhcmUoKSBob29rIG9yIG11Y2ggZWFybGllcgo+IGluIHRoZSBhdG9taWMgY2hlY2sv cHJlcGFyZSBwaGFzZT8gRllJLCBJIGFtIGp1c3QgYWRkaW5nIGEgcmVzdHJpY3Rpb24gCj4gbWVu dGlvbmVkIGluIHRoZSBzcGVjIGNvbmNlcm5pbmcgdGhpcyBEUExMLgo+IAo+ID4gCj4gPiBEb2Vz IERNQyBoYW5kbGUgb3RoZXIgTUcgUExMcz8gSSB3b3VsZCBoYXZlIHRob3VnaHQgbm90LCBzbyBp ZiB3ZSBrZWVwCj4gPiB0aGUgYXNzZXJ0IHRoZW4gaXQgc2hvdWxkIHBlcmhhcHMgYmUgdW5jb25k aXRpb25hbC4gSG1tLiBCdXQgYXJlbid0IHdlCj4gPiBzdGlsbCBob2RsaW5nIHRoZSBtb2Rlc2V0 IHBvd2VyIGRvbWFpbiB3aGVuIHRoaXMgZ2V0cyBjYWxsZWQ/IElmIHNvCj4gPiB0aGlzIGlzIGRl ZmluaXRlbHkgZGVhZCBjb2RlLgo+IEkgYW0gbm90IHN1cmUgd2hldGhlciBETUMgaGFuZGxlcyBv dGhlciBNRyBQTExzIGJ1dCB0aGUgc3BlYyBleHBsaWNpdGx5Cj4gc2F5cyB0aGF0IERNQyB3aWxs IG5vdCBoYW5kbGUgdGhpcyBQTEwuIFdoZXJlIGRvIHlvdSBzdWdnZXN0IGlzIGFuCj4gYXBwcm9w cmlhdGUgcGxhY2UgdG8gcHV0IHRoaXMgYXNzZXJ0PwoKREM1LzYgZW5hYmxlIHByb2JhYmx5IGlz IHRoZSBiZXN0LCBpZiB3ZSBldmVuIHdhbnQgdGhlIGFzc2VydC4gQW5kIEknbQpub3QgY29udmlu Y2VkIHRoYXQgd2UgZG8gc2luY2Ugd2UgZG9uJ3QgaGF2ZSBpdCBmb3IgYW55IG90aGVyIFBMTApl aXRoZXIuCgo+IAo+ID4gCj4gPiA+IAo+ID4gPiBBbHNvIHdoYXQgaXMgdGhpcyBFSEwgdGhpbmcg YW55d2F5PyBJIGNhbid0IGV2ZW4gZmluZCBpdCBpbiB0aGUKPiA+ID4gc3BlYy4gCj4gRUhMID0g RWxraGFydCBMYWtlLCBhIG5ldyBHZW4gMTEgcGxhdGZvcm0uCj4gCj4gVGhhbmtzLAo+IFZpdmVr Cj4gCj4gPiA+ID4gKwo+ID4gPiA+ICAJaWNsX3BsbF9wb3dlcl9lbmFibGUoZGV2X3ByaXYsIHBs bCwgZW5hYmxlX3JlZyk7Cj4gPiA+ID4gIAo+ID4gPiA+ICAJaWNsX21nX3BsbF93cml0ZShkZXZf cHJpdiwgcGxsKTsKPiA+ID4gPiBAQCAtMzI0OSwxMiArMzMwNiwxMyBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IGludGVsX2RwbGxfbWdyCj4gPiA+ID4gaWNsX3BsbF9tZ3IgPSB7IHN0YXRpYyBjb25z dCBzdHJ1Y3QgZHBsbF9pbmZvIGVobF9wbGxzW10gPSB7Cj4gPiA+ID4gIAl7ICJEUExMIDAiLCAm Y29tYm9fcGxsX2Z1bmNzLCBEUExMX0lEX0lDTF9EUExMMCwgMCB9LAo+ID4gPiA+ICAJeyAiRFBM TCAxIiwgJmNvbWJvX3BsbF9mdW5jcywgRFBMTF9JRF9JQ0xfRFBMTDEsIDAgfSwKPiA+ID4gPiAr CXsgIkRQTEwgNCIsICZtZ19wbGxfZnVuY3MsIERQTExfSURfSUNMX01HUExMMSwwIH0sCj4gPiA+ ID4gIAl7IH0sCj4gPiA+ID4gIH07Cj4gPiA+ID4gIAo+ID4gPiA+ICBzdGF0aWMgY29uc3Qgc3Ry dWN0IGludGVsX2RwbGxfbWdyIGVobF9wbGxfbWdyID0gewo+ID4gPiA+ICAJLmRwbGxfaW5mbyA9 IGVobF9wbGxzLAo+ID4gPiA+IC0JLmdldF9kcGxsID0gaWNsX2dldF9kcGxsLAo+ID4gPiA+ICsJ LmdldF9kcGxsID0gZWhsX2dldF9kcGxsLAo+ID4gPiA+ICAJLmR1bXBfaHdfc3RhdGUgPSBpY2xf ZHVtcF9od19zdGF0ZSwKPiA+ID4gPiAgfTsKPiA+ID4gPiAgCj4gPiA+ID4gLS0gCj4gPiA+ID4g Mi4xNC41Cj4gPiA+ID4gCj4gPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiA+ID4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiA+ID4gSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4ICAKPiA+ID4gCj4gPiA+IC0tIAo+ ID4gPiBWaWxsZSBTeXJqw6Rsw6QKPiA+ID4gSW50ZWwgIAo+ID4gCgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==