Re: [PATCH/RFC net-next] ravb: Avoid unsupported internal delay mode for R-Car E3/D3

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

^
> > > +static const struct soc_device_attribute ravb_delay_mode_quirk_match[] = {
> > > +	{ .soc_id = "r8a77990", .revision = "ES1.*" },
> > > +	{ .soc_id = "r8a77995", .revision = "ES1.*" },
> > > +	{ /* sentinel */ }
> > > +};
> > 
> > I might have missed it but is there a plan to fix this in later
> > revisions of D3/E3? I was under the impression that it is not and then
> > we could base it on compatible rather than soc_device_match?
> 
> I am not aware of any such plan (or the absence of such a plan).
> 
> I was unsure weather to go with the compat approach of the quirk approach.
> In the end I went with the quirk approach as it seems simpler. But
> I'm happy to re-arrange things.

I see. Well, I don't care super much. The tiny drawback here is that we
will have a potentially broken D3/E3 ES2.0, if they have not fixed TXID
there. Then we need to update the above pattern. So, revision = "*" (or
the compatible approach) might be a tad better. Then we "only" have 1G
disabled for no reason until we whitelist it.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]