From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6597C10F13 for ; Mon, 8 Apr 2019 15:51:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69D5D2147A for ; Mon, 8 Apr 2019 15:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554738690; bh=ucagwXC/x4eXT8P8WjmTFI1SVMEsAx3xvDZrfcFcDAM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jsefOsOXfW6K4wn8lhlWsiabM85xrGaWs5GnpIhye+L6UhwrGcNdDk4d8EUgV67Rv /BxY+Ksugqq2OAAF9z85WnFhmzey+7emKgYhGkZF9ySjF/UBHAs3HIa03pqQGaBU+Q g5Qx7kuU5a1q4fiALmrfhAHoUlE57Ac/qAwOG7BI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727030AbfDHPv3 (ORCPT ); Mon, 8 Apr 2019 11:51:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:41364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbfDHPv3 (ORCPT ); Mon, 8 Apr 2019 11:51:29 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BFFC21473; Mon, 8 Apr 2019 15:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554738688; bh=ucagwXC/x4eXT8P8WjmTFI1SVMEsAx3xvDZrfcFcDAM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jk95gLbfVq8WzbzhTgpF8Zinilggjp31PCY16SRawst3fY9uxlCL2Aqw7SmwxNNPL eiiKUnvfg9N9vvKiANhe3rdSRLTSPV7mJVnJc1LuVTyHqMVX6tGimZ3ty2P1JroHfS 50IpfiQrep3HpZI8SXMdW0JRn7mu5x3N2kV12OkQ= Date: Mon, 8 Apr 2019 11:51:27 -0400 From: Sasha Levin To: Captain Wiggum Cc: davem@davemloft.net, Greg Kroah-Hartman , Florian Westphal , Eric Dumazet , Peter Oskolkov , netdev@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net] ipv6: un-do: defrag: drop non-last frags smaller than min mtu Message-ID: <20190408155127.GH4689@sasha-vm> References: <20190405045047.GB553@kroah.com> <20190406141510.GC2935@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 08, 2019 at 08:49:52AM -0600, Captain Wiggum wrote: >Hi Sasha, > >This patch cannot be applied to upstream, the code is significantly different. >Therefore, this un-do patch would not be seen in the upstream git log. >It was solved there by coding a better solution, not by the un-do patch. Okay, so this is effectively a request to diverge the -stable tree from upstream in a non-trivial way, which is why I asked David Miller to ack this act explcitly (or to send me patches, or whatever else he thinks is appropriate here). >Please consider this: >Upstream passes the TAHI IPv6 protocol tests. All the LTS kernels do NOT. >This is the patch that causes the failure in 4.9, 4.14, 4.19 LTS kernels. I very much agree that this should get fixed. My concerns are not with the bug but are with the proposed fix as it applies to -stable trees. >And this patch has been in place with 4.9.134, a long time. >It is not right that "Linux" can not pass the IPv6 protocol test. >My executive are asking me why "Linux" is not fit for IPv6 deployments. Arguments such as this carry no weight in a more technical discussion such as this. Yes, some tests are currently broken, but we will not take shortcuts just because "executives are unhappy". -- Thanks, Sasha