From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B725C10F13 for ; Mon, 8 Apr 2019 17:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A63620870 for ; Mon, 8 Apr 2019 17:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726606AbfDHR1O (ORCPT ); Mon, 8 Apr 2019 13:27:14 -0400 Received: from mga09.intel.com ([134.134.136.24]:43140 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbfDHR1O (ORCPT ); Mon, 8 Apr 2019 13:27:14 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 10:27:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,326,1549958400"; d="scan'208";a="138545797" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.181]) by fmsmga008.fm.intel.com with ESMTP; 08 Apr 2019 10:27:13 -0700 Date: Mon, 8 Apr 2019 10:27:13 -0700 From: Sean Christopherson To: Krish Sadhukhan Cc: kvm@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com, jmattson@google.com Subject: Re: [PATCH 5/6 v4][KVM nVMX]: nested_vmx_check_vmentry_postreqs() should return VMX_EXIT_REASONS_FAILED_VMENTRY | EXIT_REASON_INVALID_STATE for error conditions Message-ID: <20190408172713.GH25880@linux.intel.com> References: <20190405014650.16880-1-krish.sadhukhan@oracle.com> <20190405014650.16880-6-krish.sadhukhan@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190405014650.16880-6-krish.sadhukhan@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Apr 04, 2019 at 09:46:49PM -0400, Krish Sadhukhan wrote: > ..to reflect the architectural Exit Reason for VM-entry failures due to > invalid guest state. > > Signed-off-by: Krish Sadhukhan > Suggested-by: Sean Christopherson > --- > arch/x86/kvm/vmx/nested.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c > index efd226d4ea36..456bf6514bb3 100644 > --- a/arch/x86/kvm/vmx/nested.c > +++ b/arch/x86/kvm/vmx/nested.c > @@ -2705,7 +2705,9 @@ static int nested_vmx_check_vmentry_postreqs(struct kvm_vcpu *vcpu, > You missed the newly added call to nested_check_guest_cregs_dregs_msrs(). Assuming you spin v5, please fix the indentation issue in patch 1/6 as well. > if (nested_vmx_check_vmcs_link_ptr(vcpu, vmcs12)) { > *exit_qual = ENTRY_FAIL_VMCS_LINK_PTR; > - return 1; > + > + return VMX_EXIT_REASONS_FAILED_VMENTRY | > + EXIT_REASON_INVALID_STATE; > } > > /* > @@ -2724,13 +2726,17 @@ static int nested_vmx_check_vmentry_postreqs(struct kvm_vcpu *vcpu, > ia32e != !!(vmcs12->guest_ia32_efer & EFER_LMA) || > ((vmcs12->guest_cr0 & X86_CR0_PG) && > ia32e != !!(vmcs12->guest_ia32_efer & EFER_LME))) > - return 1; > + > + return VMX_EXIT_REASONS_FAILED_VMENTRY | > + EXIT_REASON_INVALID_STATE; > } > > if ((vmcs12->vm_entry_controls & VM_ENTRY_LOAD_BNDCFGS) && > (is_noncanonical_address(vmcs12->guest_bndcfgs & PAGE_MASK, vcpu) || > (vmcs12->guest_bndcfgs & MSR_IA32_BNDCFGS_RSVD))) > - return 1; > + > + return VMX_EXIT_REASONS_FAILED_VMENTRY | > + EXIT_REASON_INVALID_STATE; > > return 0; > } > -- > 2.17.2 >