From: Murphy Zhou <jencce.kernel@gmail.com>
To: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk
Cc: Murphy Zhou <jencce.kernel@gmail.com>
Subject: [PATCH] fs/aio.c: fix wrong return value regression in __io_submit_one
Date: Tue, 9 Apr 2019 14:06:50 +0800 [thread overview]
Message-ID: <20190409060650.28901-1-jencce.kernel@gmail.com> (raw)
Now it returns 0 when actually error happened, causing kernel hang easily.
Fixes: 7316b49 "aio: move sanity checks and request allocation to io_submit_one()"
Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
fs/aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/aio.c b/fs/aio.c
index a4cc2a1cccb7..7ccecaab487a 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1794,7 +1794,7 @@ static int __io_submit_one(struct kioctx *ctx, const struct iocb *iocb,
*/
eventfd = eventfd_ctx_fdget(iocb->aio_resfd);
if (IS_ERR(eventfd))
- return PTR_ERR(req->ki_eventfd);
+ return PTR_ERR(eventfd);
req->ki_eventfd = eventfd;
}
--
2.21.0
next reply other threads:[~2019-04-09 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 6:06 Murphy Zhou [this message]
2019-04-09 23:13 ` [PATCH] fs/aio.c: fix wrong return value regression in __io_submit_one Al Viro
2019-04-10 2:55 ` Murphy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409060650.28901-1-jencce.kernel@gmail.com \
--to=jencce.kernel@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.