From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
Nitesh Narayan Lal <nitesh@redhat.com>,
kvm list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Paolo Bonzini <pbonzini@redhat.com>,
lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com,
Yang Zhang <yang.zhang.wz@gmail.com>,
Rik van Riel <riel@surriel.com>,
dodgen@google.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
dhildenb@redhat.com, Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: Thoughts on simple scanner approach for free page hinting
Date: Tue, 9 Apr 2019 09:37:54 -0400 [thread overview]
Message-ID: <20190409093642-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <43aa1bd2-4aac-5ac4-3bd4-fe1e4a342c79@redhat.com>
On Tue, Apr 09, 2019 at 03:36:08PM +0200, David Hildenbrand wrote:
> On 09.04.19 15:31, Michael S. Tsirkin wrote:
> > On Tue, Apr 09, 2019 at 11:20:36AM +0200, David Hildenbrand wrote:
> >> BTW I like the idea of allocating pages that have already been hinted as
> >> last "choice", allocating pages that have not been hinted yet first.
> >
> > OK I guess but note this is just a small window during which
> > not all pages have been hinted.
>
> Yes, good point. It might sound desirable but might be completely
> irrelevant in practice.
>
> >
> > So if we actually think this has value then we need
> > to design something that will desist and not drop pages
> > in steady state too.
>
> By dropping, you mean dropping hints of e.g. MAX_ORDER - 1 or e.g. not
> reporting MAX_ORDER - 3?
I mean the issue is host unmaps the pages from guest right? That is
what makes hinted pages slower than non-hinted ones. If we do not want
that to happen for some pages, then either host can defer acting on the
hint, or we can defer hinting.
> --
>
> Thanks,
>
> David / dhildenb
next prev parent reply other threads:[~2019-04-09 13:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 0:09 Thoughts on simple scanner approach for free page hinting Alexander Duyck
2019-04-08 12:24 ` Nitesh Narayan Lal
2019-04-08 15:18 ` Alexander Duyck
2019-04-08 15:41 ` Michael S. Tsirkin
2019-04-08 16:36 ` David Hildenbrand
2019-04-08 18:09 ` Nitesh Narayan Lal
2019-04-08 18:19 ` Michael S. Tsirkin
2019-04-08 18:29 ` Alexander Duyck
2019-04-08 18:58 ` David Hildenbrand
2019-04-08 18:27 ` David Hildenbrand
2019-04-08 18:18 ` Alexander Duyck
2019-04-08 18:40 ` David Hildenbrand
2019-04-08 20:10 ` Alexander Duyck
2019-04-08 20:47 ` David Hildenbrand
2019-04-08 20:51 ` David Hildenbrand
2019-04-08 21:20 ` David Hildenbrand
2019-04-08 21:56 ` Alexander Duyck
2019-04-09 2:44 ` Michael S. Tsirkin
2019-04-09 7:05 ` David Hildenbrand
2019-04-09 9:20 ` David Hildenbrand
2019-04-09 13:31 ` Michael S. Tsirkin
2019-04-09 13:36 ` David Hildenbrand
2019-04-09 13:37 ` Michael S. Tsirkin [this message]
2019-04-09 13:43 ` David Hildenbrand
2019-04-09 14:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409093642-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aarcange@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=david@redhat.com \
--cc=dhildenb@redhat.com \
--cc=dodgen@google.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nitesh@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.