From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv2] nvmet: Fix discover log page when offsets are used
Date: Tue, 9 Apr 2019 11:50:07 +0200 [thread overview]
Message-ID: <20190409095007.GC6827@lst.de> (raw)
In-Reply-To: <SN6PR04MB45279B323BEE059E7FE46BD1862D0@SN6PR04MB4527.namprd04.prod.outlook.com>
On Tue, Apr 09, 2019@02:33:04AM +0000, Chaitanya Kulkarni wrote:
> > +u64 nvmet_get_log_page_offset(struct nvme_command *cmd)
> > +{
> > + u64 offset = le32_to_cpu(cmd->get_log_page.lpou);
> > +
> > + offset <<= 32;
> > + offset += le32_to_cpu(cmd->get_log_page.lpol);
> > +
> > + return offset;
> > +}
> > +
> Can we please mark above function inline ?
Log pages are pretty much in the slow path, so despite the
triviality I don't really see a reason to inline it.
next prev parent reply other threads:[~2019-04-09 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 19:46 [PATCHv2] nvmet: Fix discover log page when offsets are used Keith Busch
2019-04-09 0:30 ` James Smart
2019-04-09 2:33 ` Chaitanya Kulkarni
2019-04-09 9:50 ` Christoph Hellwig [this message]
2019-04-09 9:54 ` Christoph Hellwig
2019-04-09 14:55 ` Keith Busch
2019-04-09 15:19 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409095007.GC6827@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.