From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@lst.de (Christoph Hellwig)
Date: Tue, 9 Apr 2019 11:54:01 +0200
Subject: [PATCHv2] nvmet: Fix discover log page when offsets are used
In-Reply-To: <20190408194652.641-1-keith.busch@intel.com>
References: <20190408194652.641-1-keith.busch@intel.com>
Message-ID: <20190409095401.GD6827@lst.de>

> +u64 nvmet_get_log_page_offset(struct nvme_command *cmd)
> +{
> +	u64 offset = le32_to_cpu(cmd->get_log_page.lpou);
> +
> +	offset <<= 32;
> +	offset += le32_to_cpu(cmd->get_log_page.lpol);
> +
> +	return offset;

Maybe just a pet peeve of fine, but can we avoid the pointless local
variable?  Why not:

	return le32_to_cpu(cmd->get_log_page.lpol) |
		(((u64)le32_to_cpu(cmd->get_log_page.lpou)) << 32);

That being said I don't get why we don't simply replace lpol and lpou
with a single __le64 to start with to simplify things further.