Re: [meta-networking][PATCH] squid: upgrade squid 3.5.28 -> 4.6

[Adrian Bunk <bunk@stusta.de>]

On Tue, Apr 09, 2019 at 10:46:21AM +0200, Andrej Valek wrote:
>...
>  - add openssl and esi as package options
>...
> -DEPENDS = "libtool krb5 openldap db cyrus-sasl openssl expat libxml2"
>...
> +DEPENDS = "libtool krb5 openldap db cyrus-sasl"
>  
>  inherit autotools pkgconfig useradd ptest perlnative
>  
> @@ -51,6 +50,8 @@ PACKAGECONFIG[libnetfilter-conntrack] = "--with-netfilter-conntrack=${includedir
>  PACKAGECONFIG[noatomics] = "squid_cv_gnu_atomics=no,squid_cv_gnu_atomics=yes,,"
>  PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6,"
>  PACKAGECONFIG[werror] = "--enable-strict-error-checking,--disable-strict-error-checking,"
> +PACKAGECONFIG[esi] = "--enable-esi,--disable-esi,expat libxml2"
> +PACKAGECONFIG[ssl] = "--with-openssl=yes,--with-openssl=no,openssl"
>...

It would be good to have such changes unrelated to the upgrade in a 
separate commit.

Unless there's a reason to do otherwise, it would be better to have 
these new options in the default PACKAGECONFIG so that a opt-out is 
possible but the default doesn't change.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed